From: "Américo Wang" <xiyou.wangcong@gmail.com>
To: Suresh Siddha <suresh.b.siddha@intel.com>
Cc: "H. Peter Anvin" <hpa@zytor.com>, Ingo Molnar <mingo@elte.hu>,
Thomas Gleixner <tglx@linutronix.de>,
LKML <linux-kernel@vger.kernel.org>,
Arjan van de Ven <arjan@linux.intel.com>
Subject: Re: [patch] x86: avoid unnecessary smp alternatives switch during suspend/resume
Date: Sun, 21 Nov 2010 14:02:51 +0800 [thread overview]
Message-ID: <20101121060251.GD9099@hack> (raw)
In-Reply-To: <1290211764.2637.8.camel@sbsiddha-MOBL3.sc.intel.com>
On Fri, Nov 19, 2010 at 04:09:24PM -0800, Suresh Siddha wrote:
>During suspend, we disable all the non boot cpus. And during resume we bring
>them all back again. So no need to do alternatives_smp_switch() in between.
>
>This speeds up both suspend and resume paths.
>
>Signed-off-by: Suresh Siddha <suresh.b.siddha@intel.com>
This is a cool idea!
The patch looks good for me, just note that kexec
also calls disable_nonboot_cpus(), so the name 'pm_sleep_smp'
is a bit confused. ;)
Reviewed-by: WANG Cong <xiyou.wangcong@gmail.com>
Thanks!
--
Live like a child, think like the god.
next prev parent reply other threads:[~2010-11-21 5:59 UTC|newest]
Thread overview: 11+ messages / expand[flat|nested] mbox.gz Atom feed top
2010-11-20 0:09 [patch] x86: avoid unnecessary smp alternatives switch during suspend/resume Suresh Siddha
2010-11-20 16:31 ` Ben Gamari
2010-11-21 6:02 ` Américo Wang [this message]
2010-11-21 9:27 ` Nigel Cunningham
2010-11-21 10:03 ` Borislav Petkov
2011-01-02 9:11 ` Pavel Machek
2011-01-03 23:44 ` Suresh Siddha
2010-11-22 2:30 ` H. Peter Anvin
2010-11-24 0:11 ` Suresh Siddha
2010-12-14 21:21 ` [tip:x86/alternatives] x86, suspend: Avoid " tip-bot for Suresh Siddha
2010-12-14 22:31 ` Rafael J. Wysocki
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20101121060251.GD9099@hack \
--to=xiyou.wangcong@gmail.com \
--cc=arjan@linux.intel.com \
--cc=hpa@zytor.com \
--cc=linux-kernel@vger.kernel.org \
--cc=mingo@elte.hu \
--cc=suresh.b.siddha@intel.com \
--cc=tglx@linutronix.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.