All of lore.kernel.org
 help / color / mirror / Atom feed
From: Shawn Bohrer <sbohrer@rgmadvisors.com>
To: Andreas Schwab <schwab@linux-m68k.org>
Cc: Arnaldo Carvalho de Melo <acme@redhat.com>,
	Ingo Molnar <mingo@elte.hu>, Paul Mackerras <paulus@samba.org>,
	Peter Zijlstra <a.p.zijlstra@chello.nl>,
	linux-kernel@vger.kernel.org
Subject: Re: [PATCH] perf: Handle DT_UNKNOWN on filesystems that don't support d_type
Date: Sun, 21 Nov 2010 09:54:33 -0600	[thread overview]
Message-ID: <20101121155433.GB2527@BohrerMBP> (raw)
In-Reply-To: <m2ipzryoz2.fsf@igel.home>

On Sun, Nov 21, 2010 at 11:01:53AM +0100, Andreas Schwab wrote:
> Shawn Bohrer <sbohrer@rgmadvisors.com> writes:
> 
> > +		if (((lang_dirent.d_type == DT_DIR &&			\
> > +		      lang_dirent.d_type != DT_UNKNOWN) ||		\
> > +		     (lang_dirent.d_type == DT_UNKNOWN &&		\
> > +		      is_directory(scripts_path, &lang_dirent))) &&	\
> 
> 		if ((lang_dirent.d_type == DT_DIR ||			\
> 		     (lang_dirent.d_type == DT_UNKNOWN &&		\
> 		      is_directory(scripts_path, &lang_dirent))) &&	\
> 
> > +		if ((script_dirent.d_type != DT_DIR &&			\
> > +		     script_dirent.d_type != DT_UNKNOWN) ||		\
> > +		    (script_dirent.d_type == DT_UNKNOWN &&		\
> > +		     !is_directory(lang_path, &script_dirent)))
> 
> 		if (script_dirent.d_type != DT_DIR &&			\
> 		    (script_dirent.d_type != DT_UNKNOWN ||		\
> 		     !is_directory(lang_path, &script_dirent)))
> 
> (DeMorgan: !(a && b) <-> (!a || !b); !(a || b) <-> (!a && !b))

Thanks Andreas, I'll send a follow up patch with the cleanup.

--
Shawn

  reply	other threads:[~2010-11-21 15:54 UTC|newest]

Thread overview: 7+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2010-11-21  0:42 [PATCH] perf: Handle DT_UNKNOWN on filesystems that don't support d_type Shawn Bohrer
2010-11-21  0:48 ` Arnaldo Carvalho de Melo
2010-11-21 15:52   ` Shawn Bohrer
2010-11-21 10:01 ` Andreas Schwab
2010-11-21 15:54   ` Shawn Bohrer [this message]
2010-11-21 16:09     ` [PATCH v2] " Shawn Bohrer
2010-11-28  8:34       ` [tip:perf/core] perf trace: " tip-bot for Shawn Bohrer

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20101121155433.GB2527@BohrerMBP \
    --to=sbohrer@rgmadvisors.com \
    --cc=a.p.zijlstra@chello.nl \
    --cc=acme@redhat.com \
    --cc=linux-kernel@vger.kernel.org \
    --cc=mingo@elte.hu \
    --cc=paulus@samba.org \
    --cc=schwab@linux-m68k.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.