From: Ralf Baechle <ralf@linux-mips.org>
To: Arnaud Patard <arnaud.patard@rtp-net.org>
Cc: shmprtd@googlemail.com, linux-mips@linux-mips.org
Subject: Re: [PATCH] Add support for Realtek Media Player SoCs
Date: Mon, 22 Nov 2010 00:41:14 +0000 [thread overview]
Message-ID: <20101122004114.GA10923@linux-mips.org> (raw)
In-Reply-To: <87r5efyozy.fsf@lechat.rtp-net.org>
On Sun, Nov 21, 2010 at 11:01:21AM +0100, Arnaud Patard wrote:
> Please read Documentation/SubmittingPatches. One big patch is just
> impossible to review (at least for me), please split it in fewer
> chunks.
This is not outrageously huge and actually well smaller than the "atoms"
some other patches were split into. Ideally patches should be split such
that each patch fixes one bug or adds one feature and such that applying
only a part of a patch series does not result in a regression. The
absolute size or number of patches at least to me is a secondary
consideration.
Ralf
next prev parent reply other threads:[~2010-11-22 0:41 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2010-11-21 0:15 [PATCH] Add support for Realtek Media Player SoCs shmprtd
2010-11-21 10:01 ` Arnaud Patard
[not found] ` <4CE8FA88.2020107@googlemail.com>
2010-11-21 11:40 ` Arnaud Patard
2010-11-22 0:41 ` Ralf Baechle [this message]
2010-11-22 2:24 ` Ralf Baechle
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20101122004114.GA10923@linux-mips.org \
--to=ralf@linux-mips.org \
--cc=arnaud.patard@rtp-net.org \
--cc=linux-mips@linux-mips.org \
--cc=shmprtd@googlemail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.