From: Christoph Hellwig <hch@lst.de>
To: Hannes Reinecke <hare@suse.de>
Cc: stefanha@gmail.com, qemu-devel@nongnu.org, nab@linux-iscsi.org,
kraxel@redhat.com
Subject: Re: [Qemu-devel] [PATCH] scsi: Use 'SCSIRequest' directly
Date: Mon, 22 Nov 2010 12:31:44 +0100 [thread overview]
Message-ID: <20101122113144.GA2013@lst.de> (raw)
In-Reply-To: <20101122101536.58B2EF90AE@ochil.suse.de>
On Mon, Nov 22, 2010 at 11:15:35AM +0100, Hannes Reinecke wrote:
>
> Currently the SCSIRequest structure is abstracted away and
> cannot accessed directly from the driver. This requires
> the handler to do a lookup on an abstract 'tag' which
> identifies the SCSIRequest structure.
> With this patch the SCSIRequest structure is exposed to
> the driver. This allows use to use it directly as an
> argument to the SCSIDeviceInfo callback functions and
> remove the lookup.
> Two new callback functions 'alloc_req' and 'free_req'
> are introduced, which serve to allocate a new request
> and to free up resources after use.
I still think having the implementations of the method named different
than the method name is a bad idea.
Otherwise looks good.
prev parent reply other threads:[~2010-11-22 11:32 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2010-11-22 10:15 [Qemu-devel] [PATCH] scsi: Use 'SCSIRequest' directly Hannes Reinecke
2010-11-22 11:31 ` Christoph Hellwig [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20101122113144.GA2013@lst.de \
--to=hch@lst.de \
--cc=hare@suse.de \
--cc=kraxel@redhat.com \
--cc=nab@linux-iscsi.org \
--cc=qemu-devel@nongnu.org \
--cc=stefanha@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.