Re: [PATCH 01/19] quota: protect getfmt call with dqonoff_mutex lock

[Jan Kara <jack@suse.cz>]

On Thu 11-11-10 15:14:20, Dmitry Monakhov wrote:
> dqptr_sem hasn't any thing in common with quota files,
> quota file load  protected with dqonoff_mutex, so we have to use
> it for reading fmt info.
  You missed ext2 and jfs from the conversion. Also you should mention that
you introduce new ->get_fmt call. Other than that just one nitpick:

> diff --git a/include/linux/quota.h b/include/linux/quota.h
> index 9a85412..2767e4c 100644
> --- a/include/linux/quota.h
> +++ b/include/linux/quota.h
> @@ -331,6 +331,7 @@ struct quotactl_ops {
>  	int (*quota_off)(struct super_block *, int);
>  	int (*quota_sync)(struct super_block *, int, int);
>  	int (*get_info)(struct super_block *, int, struct if_dqinfo *);
> +	int (*get_fmt)(struct super_block*, int, unsigned int*);
                                                             ^ space before *

									Honza
-- 
Jan Kara <jack@suse.cz>
SUSE Labs, CR