Re: [PATCH 1/4] ath: Add a driver_info bitmask field

[Christian Lamparter <chunkeey@googlemail.com>]

On Monday 22 November 2010 22:23:36 Bob Copeland wrote:
> On Fri, Nov 19, 2010 at 6:23 AM, Rajkumar Manoharan
> <rmanoharan@atheros.com> wrote:
> > The driver_info stores the device category information which
> > is used to load appropriate device firmware, select firmware offset
> > and eeprom starting location. The driver_info is accessed across
> > ath9k_htc and ath9k_hw. Hence placed under common structure.
> 
> >  /**
> >  * struct ath_ops - Register read/write operations
> >  *
> > @@ -147,6 +152,7 @@ struct ath_common {
> >        u8 rx_chainmask;
> >
> >        u32 rx_bufsize;
> > +       u32 driver_info;
> 
> 
> u32 for 2 bits?
 
well, if you take in account that mod_devicetable.h specifies
driver_info to be kernel_ulong_t... (to store pointers of course)

I would say we need "even" more.

Best regards,
	Chr