From: Christoph Hellwig <hch@infradead.org>
To: Bill Kendall <wkendall@sgi.com>
Cc: xfs@oss.sgi.com
Subject: Re: [PATCH v4 4/9] xfsrestore: mmap dirent names for faster lookups
Date: Tue, 23 Nov 2010 08:48:18 -0500 [thread overview]
Message-ID: <20101123134818.GA31206@infradead.org> (raw)
In-Reply-To: <20101119183837.GA9505@sgi.com>
On Fri, Nov 19, 2010 at 12:38:37PM -0600, Bill Kendall wrote:
> Pathname resolution in xfsrestore is about 4x faster if the file
> containing dirent names ("namreg") is memory mapped. If xfsrestore is
> unable to map the file (e.g., due to virtual memory constraints)
> fallback to the existing seek-and-read approach.
>
> The file is mapped after all directory entries have been written to
> the "namreg" file. If the caller tries to add additional entries after
> the file has been mapped, it will be unmapped and restore will resort
> back to seek-and-read lookups.
This looks much simpler indeed. Is it intentional that the namreg file
is never unmapped any more?
_______________________________________________
xfs mailing list
xfs@oss.sgi.com
http://oss.sgi.com/mailman/listinfo/xfs
next prev parent reply other threads:[~2010-11-23 13:46 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2010-11-19 18:38 [PATCH v4 4/9] xfsrestore: mmap dirent names for faster lookups Bill Kendall
2010-11-23 13:48 ` Christoph Hellwig [this message]
2010-11-29 14:28 ` Bill Kendall
2010-11-29 14:56 ` Christoph Hellwig
2010-11-29 20:42 ` Alex Elder
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20101123134818.GA31206@infradead.org \
--to=hch@infradead.org \
--cc=wkendall@sgi.com \
--cc=xfs@oss.sgi.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.