From: Mark Brown <broonie@opensource.wolfsonmicro.com>
To: Jassi Brar <jassisinghbrar@gmail.com>
Cc: alsa-devel@alsa-project.org, kgene.kim@samsung.com,
Jassi Brar <jassi.brar@samsung.com>,
june.bae@samsung.com, lrg@slimlogic.co.uk, sw.youn@samsung.com
Subject: Re: [PATCHv4 17/18] ASoC: Samsung: Generalize Kconfig symbols
Date: Tue, 23 Nov 2010 14:12:56 +0000 [thread overview]
Message-ID: <20101123141255.GH18960@rakim.wolfsonmicro.main> (raw)
In-Reply-To: <1290407842-29591-1-git-send-email-jassisinghbrar@gmail.com>
On Mon, Nov 22, 2010 at 03:37:22PM +0900, Jassi Brar wrote:
> SND_SOC_SMDK_SPDIF -> ASOC_SAMSUNG_SMDK_SPDIF
> SND_SOC_SMDK_WM8580 -> ASOC_SAMSUNG_SMDK_WM8580
> SND_SOC_SMDK_WM9713 -> ASOC_SAMSUNG_SMDK_WM9713
> SND_SOC_GONI_AQUILA_WM8994 -> ASOC_GONI_AQUILA_WM8994
Hrm. These ones I'm not entirely happy about - we're pretty
consistently using SND_SOC_ rather than ASOC_ throughout the subsystem
so changing to ASOC_ feels like churn. Is there any great reason for
the rename? I don't mind the addition of SAMSUNG_ one way or the other,
it's just the subsystem prefix.
I've applied this just now as the rename patch depends on it.
next prev parent reply other threads:[~2010-11-23 14:13 UTC|newest]
Thread overview: 46+ messages / expand[flat|nested] mbox.gz Atom feed top
2010-10-26 1:30 [PATCHv3] ASoC: Overhaul Samsung drivers Jassi Brar
2010-10-26 1:31 ` [PATCH 01/18] ASoC: Samsung: Remove redundant AQUILA driver Jassi Brar
2010-10-26 1:32 ` [PATCH 02/18] ASoC: Samsung: Rename DMA device Jassi Brar
2010-10-26 1:33 ` [PATCH 03/18] ARM: Samsung: Define common audio-dma device Jassi Brar
2010-10-26 1:33 ` [PATCH 05/18] ASoC: Samsung: Rename AC97 platform device Jassi Brar
2010-10-26 1:33 ` [PATCH 04/18] ASoC: Samsung: Rename ASoC DMA driver Jassi Brar
2010-10-26 1:33 ` [PATCH 06/18] ASoC: Samsung: Rename AC97 driver Jassi Brar
2010-10-26 1:33 ` [PATCH 08/18] ASoC: Samsung: Generalize DMA driver namespace Jassi Brar
2010-10-26 1:33 ` [PATCH 09/18] ASoC: Samsung: Rename s3c64xx I2S device Jassi Brar
2010-10-26 1:33 ` [PATCH 07/18] ASoC: Samsung: Rename PCM driver Jassi Brar
2010-10-26 1:33 ` [PATCH 13/18] ASoC: SMDK64XX: Move to use new I2S driver Jassi Brar
2010-10-26 1:33 ` [PATCH 10/18] ASoC: Samsung: Add common " Jassi Brar
2010-10-26 1:33 ` [PATCH 11/18] ASoC: SMARTQ: Move to use new " Jassi Brar
2010-10-26 1:33 ` [PATCH 12/18] ASoC: GONI: " Jassi Brar
2010-10-26 1:33 ` [PATCH 14/18] ASoC: S3C64XX: Remove obsoleted I2S drivers Jassi Brar
2010-10-26 1:33 ` [PATCH 16/18] ASoC: SMDK_WM8580: Enable for SMDKC100 Jassi Brar
2010-10-26 1:33 ` [PATCH 15/18] ASoC: SMDK64XX: Rename for other platforms Jassi Brar
2010-10-26 1:33 ` [PATCH 17/18] ASoC: Samsung: Generalize Kconfig symbols Jassi Brar
2010-10-26 1:33 ` [PATCH 18/18] ASoC: Samsung: Rename from s3c24xx to samsung Jassi Brar
2010-11-22 6:34 ` [PATCHv4] ASoC: Overhaul Samsung drivers Jassi Brar
2010-11-22 6:35 ` [PATCHv4 01/18] ASoC: Samsung: Remove redundant AQUILA driver Jassi Brar
2010-11-22 6:35 ` [PATCHv4 02/18] ASoC: Samsung: Rename DMA device Jassi Brar
2010-11-22 7:05 ` Kukjin Kim
2010-11-22 6:35 ` [PATCHv4 03/18] ARM: Samsung: Define common audio-dma device Jassi Brar
2010-11-22 7:07 ` Kukjin Kim
2010-11-22 6:35 ` [PATCHv4 04/18] ASoC: Samsung: Rename ASoC DMA driver Jassi Brar
2010-11-22 6:36 ` [PATCHv4 05/18] ASoC: Samsung: Rename AC97 platform device Jassi Brar
2010-11-22 7:09 ` Kukjin Kim
2010-11-22 6:36 ` [PATCHv4 06/18] ASoC: Samsung: Rename AC97 driver Jassi Brar
2010-11-22 6:36 ` [PATCHv4 07/18] ASoC: Samsung: Rename PCM driver Jassi Brar
2010-11-22 6:36 ` [PATCHv4 08/18] ASoC: Samsung: Generalize DMA driver namespace Jassi Brar
2010-11-22 6:36 ` [PATCHv4 09/18] ASoC: Samsung: Rename s3c64xx I2S device Jassi Brar
2010-11-22 6:36 ` [PATCHv4 10/18] ASoC: Samsung: Add common I2S driver Jassi Brar
2010-11-22 6:37 ` [PATCHv4 11/18] ASoC: SMARTQ: Move to use new " Jassi Brar
2010-11-22 6:37 ` [PATCHv4 12/18] ASoC: GONI: " Jassi Brar
2010-11-22 6:37 ` [PATCHv4 13/18] ASoC: SMDK64XX: " Jassi Brar
2010-11-22 6:37 ` [PATCHv4 14/18] ASoC: S3C64XX: Remove obsoleted I2S drivers Jassi Brar
2010-11-22 6:37 ` [PATCHv4 15/18] ASoC: SMDK64XX: Rename for other platforms Jassi Brar
2010-11-22 6:37 ` [PATCHv4 16/18] ASoC: SMDK_WM8580: Enable for SMDKC100 Jassi Brar
2010-11-22 7:13 ` Kukjin Kim
2010-11-22 6:37 ` [PATCHv4 17/18] ASoC: Samsung: Generalize Kconfig symbols Jassi Brar
2010-11-23 14:12 ` Mark Brown [this message]
2010-11-23 14:16 ` Jassi Brar
2010-11-23 14:25 ` Mark Brown
2010-11-22 6:37 ` [PATCHv4 18/18] ASoC: Samsung: Rename from s3c24xx to samsung Jassi Brar
2010-11-23 14:23 ` [PATCHv4] ASoC: Overhaul Samsung drivers Mark Brown
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20101123141255.GH18960@rakim.wolfsonmicro.main \
--to=broonie@opensource.wolfsonmicro.com \
--cc=alsa-devel@alsa-project.org \
--cc=jassi.brar@samsung.com \
--cc=jassisinghbrar@gmail.com \
--cc=june.bae@samsung.com \
--cc=kgene.kim@samsung.com \
--cc=lrg@slimlogic.co.uk \
--cc=sw.youn@samsung.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.