From: Ted Ts'o <tytso@mit.edu>
To: Lukas Czerner <lczerner@redhat.com>
Cc: sandeen@redhat.com, adilger@dilger.ca, linux-ext4@vger.kernel.org
Subject: Re: [5/6] mke2fs: Use unix_discard() for discards
Date: Tue, 23 Nov 2010 10:18:18 -0500 [thread overview]
Message-ID: <20101123151818.GE32759@thunk.org> (raw)
In-Reply-To: <1290087521-9123-6-git-send-email-lczerner@redhat.com>
On Thu, Nov 18, 2010 at 03:38:40AM -0000, Lukas Czerner wrote:
> There is generic discard function in struct_io_manager, or in
> unix_io_manager to be specific. So use this instead of
> mke2fs_discard_blocks().
>
> Since mke2fs_discard_blocks() is not used anymore (and should not be)
> remove it.
>
> Signed-off-by: Lukas Czerner <lczerner@redhat.com>
Changed to use io_channel_discard() instead of derferencing the
function pointer directly. I've applied this to the master branch.
- Ted
next prev parent reply other threads:[~2010-11-23 15:18 UTC|newest]
Thread overview: 14+ messages / expand[flat|nested] mbox.gz Atom feed top
2010-11-18 13:38 [PATCH 0/6 v2] e2fsprogs: Using discard in e2fsprogs tools Lukas Czerner
2010-11-18 13:38 ` [PATCH 1/6] e2fsprogs: Add discard function into struct_io_manager Lukas Czerner
2010-11-23 14:54 ` [1/6] " Ted Ts'o
2010-12-02 8:34 ` Lukas Czerner
2010-11-18 13:38 ` [PATCH 2/6] e2fsprogs: Add CHANNEL_FLAGS_DISCARD_ZEROES flag for io_manager Lukas Czerner
2010-11-23 14:55 ` [2/6] " Ted Ts'o
2010-11-18 13:38 ` [PATCH 3/6] e2fsck: Discard free data and inode blocks Lukas Czerner
2010-11-23 15:17 ` [3/6] " Ted Ts'o
2010-11-18 13:38 ` [PATCH 4/6] mke2fs: Deprecate -K option, introduce discard/nodiscard Lukas Czerner
2010-11-23 15:17 ` [4/6] " Ted Ts'o
2010-11-18 13:38 ` [PATCH 5/6] mke2fs: Use unix_discard() for discards Lukas Czerner
2010-11-23 15:18 ` Ted Ts'o [this message]
2010-11-18 13:38 ` [PATCH 6/6] mke2fs: Add discard option into mke2fs.conf Lukas Czerner
2010-11-23 15:18 ` [6/6] " Ted Ts'o
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20101123151818.GE32759@thunk.org \
--to=tytso@mit.edu \
--cc=adilger@dilger.ca \
--cc=lczerner@redhat.com \
--cc=linux-ext4@vger.kernel.org \
--cc=sandeen@redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.