All of lore.kernel.org
 help / color / mirror / Atom feed
From: Sukadev Bhattiprolu <sukadev@linux.vnet.ibm.com>
To: Eric Blake <eblake@redhat.com>
Cc: linux-fsdevel@vger.kernel.org, chet.ramey@case.edu,
	bug-bash@gnu.org, chet@po.cwru.edu,
	Matthew Wilcox <matthew@wil.cx>
Subject: Re: bash: Correct usage of F_SETFD
Date: Tue, 23 Nov 2010 09:51:57 -0800	[thread overview]
Message-ID: <20101123175157.GA8230@us.ibm.com> (raw)
In-Reply-To: <4CEBD50E.7050405@redhat.com>

Eric Blake [eblake@redhat.com] wrote:
| > 
| > So if bash is the one creating its file descriptors, there's no need to
| > use R/M/W since it knows what the state of them are.
| 
| No, bash cannot reasonably know what the implementation's default bit
| state is, and blindly setting all other bits to zero is very possibly a
| bug, and easy enough to avoid by using the full R/M/W.

Besides, if user sets a flag on the fd and execs bash, bash would clobber
the flag. IOW, assuming that bash is the one creating the fd is not always
safe right ?

Thanks,

Sukadev

  reply	other threads:[~2010-11-23 17:51 UTC|newest]

Thread overview: 8+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2010-11-22 20:16 bash: Correct usage of F_SETFD Sukadev Bhattiprolu
2010-11-22 22:16 ` Chet Ramey
2010-11-22 22:27   ` Eric Blake
2010-11-23  0:04     ` Sukadev Bhattiprolu
2010-11-23 14:42       ` Matthew Wilcox
2010-11-23 14:51         ` Eric Blake
2010-11-23 17:51           ` Sukadev Bhattiprolu [this message]
2010-11-24  1:17     ` Jamie Lokier

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20101123175157.GA8230@us.ibm.com \
    --to=sukadev@linux.vnet.ibm.com \
    --cc=bug-bash@gnu.org \
    --cc=chet.ramey@case.edu \
    --cc=chet@po.cwru.edu \
    --cc=eblake@redhat.com \
    --cc=linux-fsdevel@vger.kernel.org \
    --cc=matthew@wil.cx \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.