From: Jonathan Nieder <jrnieder@gmail.com>
To: Erik Faye-Lund <kusmabite@gmail.com>
Cc: git@vger.kernel.org, msysgit@googlegroups.com, j6t@kdbg.org,
gitster@pobox.com
Subject: Re: [RFC PATCH 1/6] msvc: opendir: use xmalloc
Date: Tue, 23 Nov 2010 12:02:50 -0600 [thread overview]
Message-ID: <20101123180250.GF12113@burratino> (raw)
In-Reply-To: <AANLkTiknTQp96PeiBd+MqCO6uEs1mCzFYDsW8NwYpBsm@mail.gmail.com>
Erik Faye-Lund wrote:
> The motivation is just to avoid having to deal with the error, like we
> do other places. It's not a big deal though. I could also set errno to
> ENOMEM and return NULL if that's preferable. I just don't see how it
> is.
I don't disagree; just fishing for a commit message. :)
> I also slightly dislike setting an error not listed in POSIX'
> documentation of opendir, even though it's probably allowed.
For future reference, here's what POSIX has to say.
Implementations shall not generate a different error
number from one required by this volume of
POSIX.1-2008 for an error condition described in this
volume of POSIX.1-2008, but may generate additional
errors unless explicitly disallowed for a particular
function.
So ENOMEM would have been allowed from that front.
next prev parent reply other threads:[~2010-11-23 18:03 UTC|newest]
Thread overview: 18+ messages / expand[flat|nested] mbox.gz Atom feed top
2010-11-23 17:30 [RFC PATCH 0/6] win32-dirent Erik Faye-Lund
2010-11-23 17:30 ` [RFC PATCH 1/6] msvc: opendir: use xmalloc Erik Faye-Lund
2010-11-23 17:40 ` Jonathan Nieder
2010-11-23 17:45 ` Erik Faye-Lund
2010-11-23 18:00 ` Erik Faye-Lund
2010-11-23 18:02 ` Jonathan Nieder [this message]
2010-11-23 18:12 ` Erik Faye-Lund
2010-11-23 17:30 ` [RFC PATCH 2/6] msvc: opendir: allocate enough memory Erik Faye-Lund
2010-11-23 17:42 ` Jonathan Nieder
2010-11-23 17:46 ` Erik Faye-Lund
2010-11-23 17:30 ` [RFC PATCH 3/6] msvc: opendir: do not start the search Erik Faye-Lund
2010-11-23 17:30 ` [RFC PATCH 4/6] win32: dirent: handle errors Erik Faye-Lund
2010-11-23 17:30 ` [RFC PATCH 5/6] msvc: opendir: handle paths ending with a slash Erik Faye-Lund
2010-11-23 17:43 ` Jonathan Nieder
2010-11-23 17:47 ` Erik Faye-Lund
2010-11-23 17:30 ` [RFC PATCH 6/6] win32: use our own dirent.h Erik Faye-Lund
2010-11-23 17:45 ` Jonathan Nieder
2010-11-23 17:51 ` Erik Faye-Lund
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20101123180250.GF12113@burratino \
--to=jrnieder@gmail.com \
--cc=git@vger.kernel.org \
--cc=gitster@pobox.com \
--cc=j6t@kdbg.org \
--cc=kusmabite@gmail.com \
--cc=msysgit@googlegroups.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.