All of lore.kernel.org
 help / color / mirror / Atom feed
From: Stefan Roese <sr@denx.de>
To: u-boot@lists.denx.de
Subject: [U-Boot] [PATCH] Fix NAND booting make target
Date: Tue, 23 Nov 2010 20:28:17 +0100	[thread overview]
Message-ID: <201011232028.17618.sr@denx.de> (raw)
In-Reply-To: <20101123125114.0af65d73@udp111988uds.am.freescale.net>

On Tuesday 23 November 2010 19:51:14 Scott Wood wrote:
> > > Yes, current git head fails to build an many 4xx boards. My patch is on
> > > top of Wolfgangs patchset "[PATCH 0/7] Address partial linking issues"
> > > from 2010-11-21 which fixes most of the 4xx problems. But without this
> > > patch, no object was built in the nand_spl directory at all. Not sure
> > > if I overlooked something though.
> > 
> > Perhaps it has to do with the 4xx boards having NAND_U_BOOT directly in
> > boards.cfg, while the Freescale boards typically have NAND there, and
> > define NAND_U_BOOT in the makefile.
> > 
> > I think the proper fix is to figure out how those quotes are being
> > injected into the make variable.
> 
> Try removing the "=y" in boards.cfg.  tools/scripts/define2mk.sed will
> add quotes to things that aren't numbers, but it has special handling
> to turn empty defines (or the number 1) into an unquoted y.

Yes, this works as well. I'll send an updated patch tomorrow.

Thanks.
 
Cheers,
Stefan

--
DENX Software Engineering GmbH,      MD: Wolfgang Denk & Detlev Zundel
HRB 165235 Munich,  Office: Kirchenstr.5, D-82194 Groebenzell, Germany
Phone: (+49)-8142-66989-0 Fax: (+49)-8142-66989-80 Email: office at denx.de

      reply	other threads:[~2010-11-23 19:28 UTC|newest]

Thread overview: 6+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2010-11-23 13:32 [U-Boot] [PATCH] Fix NAND booting make target Stefan Roese
2010-11-23 17:27 ` Scott Wood
2010-11-23 18:16   ` Stefan Roese
2010-11-23 18:45     ` Scott Wood
2010-11-23 18:51       ` Scott Wood
2010-11-23 19:28         ` Stefan Roese [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=201011232028.17618.sr@denx.de \
    --to=sr@denx.de \
    --cc=u-boot@lists.denx.de \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.