All of lore.kernel.org
 help / color / mirror / Atom feed
From: Dave Jones <davej@redhat.com>
To: Neil Brown <neilb@suse.de>
Cc: x86@kernel.org, cpufreq@vger.kernel.org, linux-kernel@vger.kernel.org
Subject: Re: Missing "unregister_cpu_notifier" in powernow-k8.c
Date: Tue, 23 Nov 2010 21:19:38 -0500	[thread overview]
Message-ID: <20101124021938.GB1987@redhat.com> (raw)
In-Reply-To: <20101124112801.78830fba@notabene.brown>

On Wed, Nov 24, 2010 at 11:28:01AM +1100, Neil Brown wrote:
 > 
 > Hi,
 >  (hope I got the right addressees above....)
 > 
 >  I appears that when powernow-k8 find that 
 > 
 >     No compatible ACPI _PSS objects found.
 > 
 >  and suggests
 > 
 >     Try again with latest BIOS.
 > 
 >  it fails the module load, but does not unregister the cpu_notifier that was 
 >  registered in powernowk8_init
 > 
 >  This ends up leaving freed memory on the cpu notifier list for some other
 >  poor module (e.g. md/raid5) to come along and trip over.
 > 
 >  The following might be a partial fix, but I suspect there is probably other
 >  clean-up that is needed.
 > 
 >  ( https://bugzilla.novell.com/show_bug.cgi?id=655215 has full dmesg traces).
 
Ouch, I'm surprised that took so long to turn up.
I'll merge this up. It should go to stable too.

thanks,

	Dave


  reply	other threads:[~2010-11-24  2:19 UTC|newest]

Thread overview: 9+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2010-11-24  0:28 Missing "unregister_cpu_notifier" in powernow-k8.c Neil Brown
2010-11-24  2:19 ` Dave Jones [this message]
2010-11-24  2:31   ` Dave Jones
2010-11-24  9:02     ` Borislav Petkov
2010-11-24 13:13       ` Borislav Petkov
2010-11-24 13:19         ` [PATCH 1/2] x86, powernow-k8: Fixup missing _PSS objects message Borislav Petkov
2010-11-24 13:19           ` Borislav Petkov
2010-11-24 13:19         ` [PATCH 2/2] x86, powernow-k8: Fix exit path Borislav Petkov
2010-11-24 13:19           ` Borislav Petkov

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20101124021938.GB1987@redhat.com \
    --to=davej@redhat.com \
    --cc=cpufreq@vger.kernel.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=neilb@suse.de \
    --cc=x86@kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.