From: Wolfram Sang <w.sang@pengutronix.de>
To: Takashi Iwai <tiwai@suse.de>
Cc: Chris Ball <cjb@laptop.org>,
linux-mmc@vger.kernel.org, linux-kernel@vger.kernel.org,
Aries Lee <arieslee@jmicron.com>
Subject: Re: [PATCH 1/2] mmc: Add support for JMicron 388 SD/MMC controller
Date: Wed, 24 Nov 2010 10:59:35 +0100 [thread overview]
Message-ID: <20101124095935.GA6812@pengutronix.de> (raw)
In-Reply-To: <1290579674-4616-2-git-send-email-tiwai@suse.de>
[-- Attachment #1: Type: text/plain, Size: 564 bytes --]
On Wed, Nov 24, 2010 at 07:21:13AM +0100, Takashi Iwai wrote:
> +/* Controller doesn't support VDD 180 for MMC (for SD/MMC combo chips) */
> +#define SDHCI_QUIRK_MMC_VDD_180 (1<<30)
Can't we handle this more generic? Like setting ocr_avail_* from
sdhci-pci.c somehow (just brainstorming, didn't have a deeper look)? I'd
like to avoid new quirks as much as possible.
Regards,
Wolfram
--
Pengutronix e.K. | Wolfram Sang |
Industrial Linux Solutions | http://www.pengutronix.de/ |
[-- Attachment #2: Digital signature --]
[-- Type: application/pgp-signature, Size: 198 bytes --]
next prev parent reply other threads:[~2010-11-24 9:59 UTC|newest]
Thread overview: 13+ messages / expand[flat|nested] mbox.gz Atom feed top
2010-11-24 6:21 [PATCH 0/2] mmc: Add support for JMicron 388 SD/MMC controller Takashi Iwai
2010-11-24 6:21 ` [PATCH 1/2] " Takashi Iwai
2010-11-24 9:59 ` Wolfram Sang [this message]
2010-11-24 11:29 ` Takashi Iwai
2010-11-24 22:04 ` Wolfram Sang
2010-12-07 16:14 ` Takashi Iwai
2010-11-24 6:21 ` [PATCH 2/2] mmc: Test bus-width for old MMC devices Takashi Iwai
2010-12-05 4:02 ` Chris Ball
2010-12-05 10:50 ` Takashi Iwai
2010-12-05 18:40 ` Chris Ball
2010-12-06 1:53 ` Philip Rakity
2010-12-15 4:03 ` zhangfei gao
2010-12-15 6:41 ` Takashi Iwai
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20101124095935.GA6812@pengutronix.de \
--to=w.sang@pengutronix.de \
--cc=arieslee@jmicron.com \
--cc=cjb@laptop.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-mmc@vger.kernel.org \
--cc=tiwai@suse.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.