From: Mark Brown <broonie@opensource.wolfsonmicro.com>
To: Takashi Iwai <tiwai@suse.de>
Cc: alsa-devel@alsa-project.org,
Sailaja Bandarupalli <sailaja.bandarupalli@intel.com>,
ramesh.babu@intel.com
Subject: Re: [PATCH 2/5] [RFC]intel_hdmi_audio: interface module
Date: Wed, 24 Nov 2010 10:11:00 +0000 [thread overview]
Message-ID: <20101124101100.GC5139@opensource.wolfsonmicro.com> (raw)
In-Reply-To: <s5h8w0jnlby.wl%tiwai@suse.de>
On Wed, Nov 24, 2010 at 10:05:05AM +0100, Takashi Iwai wrote:
> Mark Brown wrote:
> > On Mon, Nov 22, 2010 at 07:09:43PM +0530, ramesh.babu@intel.com wrote:
> > > + intelhaddata = device->device_data;
> > This function doesn't appear to do anything like what either the
> > description or name would suggest? I'd expect to see some deallocation
> > going on...
> Reading through the code, the construct doesn't seem to allocate any
> private stuff but only standard components, so this callback doesn't
> have to do anything much, I suppose.
To be honest half the issue was the above quoted line - if the function
had been empty I'd have been less concerned (and probably just said to
remove it).
next prev parent reply other threads:[~2010-11-24 10:10 UTC|newest]
Thread overview: 22+ messages / expand[flat|nested] mbox.gz Atom feed top
2010-11-22 13:39 [PATCH 1/5] [RFC]intel_hdmi_audio:include header ramesh.babu
2010-11-22 13:39 ` [PATCH 2/5] [RFC]intel_hdmi_audio: interface module ramesh.babu
2010-11-22 13:58 ` Mark Brown
2010-11-24 9:05 ` Takashi Iwai
2010-11-24 10:11 ` Mark Brown [this message]
2010-11-24 14:20 ` Takashi Iwai
2010-11-25 5:54 ` Bandarupalli, Sailaja
2010-12-01 9:55 ` Babu, Ramesh
2010-11-22 13:39 ` [PATCH 3/5] [RFC]intel_hdmi_audio: driver module - ALSA intereaction ramesh.babu
2010-11-24 9:16 ` Takashi Iwai
2010-11-25 5:40 ` Bandarupalli, Sailaja
2010-11-25 5:50 ` Takashi Iwai
2010-11-25 6:17 ` Bandarupalli, Sailaja
2010-11-22 13:39 ` [PATCH 4/5] [RFC]intel_hdmi_audio:driver module-hdmi hw interface ramesh.babu
2010-11-22 13:39 ` [PATCH 5/5] [RFC]intel_hdmi_audio: Kconfig and Makefile ramesh.babu
2010-11-22 13:48 ` [PATCH 1/5] [RFC]intel_hdmi_audio:include header Mark Brown
2010-11-25 4:59 ` Bandarupalli, Sailaja
2010-11-24 9:20 ` Takashi Iwai
2010-11-25 5:06 ` Bandarupalli, Sailaja
2010-11-25 5:46 ` Takashi Iwai
2010-11-25 6:07 ` Bandarupalli, Sailaja
2010-11-25 6:25 ` Takashi Iwai
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20101124101100.GC5139@opensource.wolfsonmicro.com \
--to=broonie@opensource.wolfsonmicro.com \
--cc=alsa-devel@alsa-project.org \
--cc=ramesh.babu@intel.com \
--cc=sailaja.bandarupalli@intel.com \
--cc=tiwai@suse.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.