From: Jarkko Nikula <jhnikula@gmail.com>
To: Axel Lin <axel.lin@gmail.com>
Cc: linux-kernel <linux-kernel@vger.kernel.org>,
Grazvydas Ignotas <notasas@gmail.com>,
Liam Girdwood <lrg@slimlogic.co.uk>,
Mark Brown <broonie@opensource.wolfsonmicro.com>,
linux-omap@vger.kernel.org
Subject: Re: [PATCH 1/2] ASoC: Return proper error for omap3pandora_soc_init
Date: Wed, 24 Nov 2010 10:33:38 +0200 [thread overview]
Message-ID: <20101124103338.76d4b5f5.jhnikula@gmail.com> (raw)
In-Reply-To: <1290583248.20639.1.camel@mola>
On Wed, 24 Nov 2010 15:20:48 +0800
Axel Lin <axel.lin@gmail.com> wrote:
> Return PTR_ERR(omap3pandora_dac_reg) instead of 0 if regulator_get failed.
>
> Signed-off-by: Axel Lin <axel.lin@gmail.com>
> ---
> sound/soc/omap/omap3pandora.c | 1 +
> 1 files changed, 1 insertions(+), 0 deletions(-)
>
> diff --git a/sound/soc/omap/omap3pandora.c b/sound/soc/omap/omap3pandora.c
> index bff9864..8047c52 100644
> --- a/sound/soc/omap/omap3pandora.c
> +++ b/sound/soc/omap/omap3pandora.c
> @@ -307,6 +307,7 @@ static int __init omap3pandora_soc_init(void)
> pr_err(PREFIX "Failed to get DAC regulator from %s: %ld\n",
> dev_name(&omap3pandora_snd_device->dev),
> PTR_ERR(omap3pandora_dac_reg));
> + ret = PTR_ERR(omap3pandora_dac_reg);
> goto fail3;
> }
Acked-by: Jarkko Nikula <jhnikula@gmail.com>
next prev parent reply other threads:[~2010-11-24 8:33 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2010-11-24 7:20 [PATCH 1/2] ASoC: Return proper error for omap3pandora_soc_init Axel Lin
2010-11-24 7:23 ` [PATCH 2/2] ASoC: Fix resource reclaim for osk5912 Axel Lin
2010-11-24 8:33 ` Jarkko Nikula
2010-11-24 8:37 ` Varadarajan, Charulatha
2010-11-24 10:50 ` Liam Girdwood
2010-11-24 10:50 ` Liam Girdwood
2010-11-24 8:33 ` Jarkko Nikula [this message]
2010-11-24 10:49 ` [PATCH 1/2] ASoC: Return proper error for omap3pandora_soc_init Liam Girdwood
2010-11-24 11:30 ` Mark Brown
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20101124103338.76d4b5f5.jhnikula@gmail.com \
--to=jhnikula@gmail.com \
--cc=axel.lin@gmail.com \
--cc=broonie@opensource.wolfsonmicro.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-omap@vger.kernel.org \
--cc=lrg@slimlogic.co.uk \
--cc=notasas@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.