From: Dan Carpenter <error27@gmail.com>
To: Al Cho <acho@novell.com>
Cc: gregkh@suse.de, linux-kernel@vger.kernel.org,
devel@driverdev.osuosl.org, yiyingc@ene.com.tw, jlee@novell.com,
segooon@gmail.com
Subject: Re: [PATCH] staging/keucr: fix keucr init coding style
Date: Wed, 24 Nov 2010 16:00:03 +0300 [thread overview]
Message-ID: <20101124130002.GA12939@bicker> (raw)
In-Reply-To: <1290600809-11352-1-git-send-email-acho@novell.com>
On Wed, Nov 24, 2010 at 08:13:29PM +0800, Al Cho wrote:
> - {
> - unsigned int pipe = fDir == FDIR_READ ? us->recv_bulk_pipe : us->send_bulk_pipe;
> - // Bulk
> + if (buf) {
> + unsigned int pipe = fDir == \
> + FDIR_READ ? us->recv_bulk_pipe : us->send_bulk_pipe;
> + /* Bulk */
This isn't a macro so the '\' character isn't needed. Although it still
compiles fine so maybe it isn't a big deal. I would probably do:
unsigned int pipe;
if (fDir == FDIR_READ)
pipe = us->recv_bulk_pipe;
else
pipe = us->send_bulk_pipe;
Otherwise it looks good.
regards,
dan carpenter
prev parent reply other threads:[~2010-11-24 13:00 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2010-11-24 12:13 [PATCH] staging/keucr: fix keucr init coding style Al Cho
2010-11-24 13:00 ` Dan Carpenter [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20101124130002.GA12939@bicker \
--to=error27@gmail.com \
--cc=acho@novell.com \
--cc=devel@driverdev.osuosl.org \
--cc=gregkh@suse.de \
--cc=jlee@novell.com \
--cc=linux-kernel@vger.kernel.org \
--cc=segooon@gmail.com \
--cc=yiyingc@ene.com.tw \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.