Re: [PATCH] ACPI video: Add video_switch_key option

[Matthew Garrett <mjg59@srcf.ucam.org>]

On Wed, Nov 24, 2010 at 08:05:35AM +0100, Takashi Iwai wrote:
> Hi,
> 
> At Wed, 27 Oct 2010 12:39:17 +0200,
> Takashi Iwai wrote:
> > Some HP laptops send ACPI video events per lid open/close, and the
> > ACPI video driver translates to SWITCHVIDEOMODE input key events.
> > This behavior confuses the user-space daemon such as
> > gnome-settings-daemon since it changes the video mode per this key,
> > which results in a different video mode at each time you open/close
> > the laptop lid.  Fn-Fx keys are handled differently on such hardware,
> > thus this key generation is simply superfluous.
> > 
> > This patch adds a module parameter "video_switch_key" to either
> > assign a different key code for this ACPI event or disable by setting
> > zero there.
> > 
> > Signed-off-by: Takashi Iwai <tiwai@suse.de>
> 
> Any comments on this patch?

I'm not entirely clear on why this is wanted. Lid state changes seem to 
be a reasonable proxy for "Reprobe outputs" - what's userspace actually 
doing that causes problems?

-- 
Matthew Garrett | mjg59@srcf.ucam.org