From: Evgeniy Polyakov <zbr@ioremap.net>
To: Ky Srinivasan <ksrinivasan@novell.com>
Cc: devel@driverdev.osuosl.org,
Haiyang Zhang <haiyangz@microsoft.com>, Greg KH <gregkh@suse.de>,
Virtualization@lists.osdl.org,
Stephen Hemminger <shemminger@vyatta.com>
Subject: Re: [PATCH 2/3]: An Implementation of HyperV KVP functionality
Date: Wed, 24 Nov 2010 17:56:17 +0300 [thread overview]
Message-ID: <20101124145617.GA11133@ioremap.net> (raw)
In-Reply-To: <4CEA6FBE0200003000090BC0@novprvoes0310.provo.novell.com>
Hi.
I will ack connector part of course, but this hunk is actually quite
bad.
> +static void shutdown_onchannelcallback(void *context)
> +{
> + struct vmbus_channel *channel = context;
> + u8 *buf;
> + u32 buflen, recvlen;
> + u64 requestid;
> + u8 execute_shutdown = false;
> +
> + struct shutdown_msg_data *shutdown_msg;
> +
> + struct icmsg_hdr *icmsghdrp;
> + struct icmsg_negotiate *negop = NULL;
> +
> + buflen = PAGE_SIZE;
> + buf = kmalloc(buflen, GFP_ATOMIC);
> +
> + vmbus_recvpacket(channel, buf, buflen, &recvlen, &requestid);
Boom. I did not read further, since this function returns void and thus
can not propagate error, which is likely not a good idea.
--
Evgeniy Polyakov
next prev parent reply other threads:[~2010-11-24 14:56 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2010-11-22 20:27 [PATCH 2/3]: An Implementation of HyperV KVP functionality Ky Srinivasan
2010-11-24 14:56 ` Evgeniy Polyakov [this message]
2010-11-29 18:26 ` Ky Srinivasan
-- strict thread matches above, loose matches on Subject: below --
2010-12-07 22:25 [PATCH 2/3]: An implementation " Ky Srinivasan
2010-12-07 22:29 ` Evgeniy Polyakov
2010-12-07 23:19 ` Ky Srinivasan
2010-12-08 18:09 ` Hank Janssen
2010-12-07 23:12 ` Greg KH
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20101124145617.GA11133@ioremap.net \
--to=zbr@ioremap.net \
--cc=Virtualization@lists.osdl.org \
--cc=devel@driverdev.osuosl.org \
--cc=gregkh@suse.de \
--cc=haiyangz@microsoft.com \
--cc=ksrinivasan@novell.com \
--cc=shemminger@vyatta.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.