All of lore.kernel.org
 help / color / mirror / Atom feed
From: Frederic Weisbecker <fweisbec@gmail.com>
To: Peter Zijlstra <a.p.zijlstra@chello.nl>
Cc: Corey Ashford <cjashfor@linux.vnet.ibm.com>,
	Paul Mackerras <paulus@samba.org>, Ingo Molnar <mingo@elte.hu>,
	Arnaldo Carvalho de Melo <acme@redhat.com>,
	Stephane Eranian <eranian@google.com>,
	Julia Lawall <julia@diku.dk>, Tom Zanussi <tzanussi@gmail.com>,
	linux-kernel@vger.kernel.org,
	Matt Fleming <matt@console-pimps.org>
Subject: Re: [RFC PATCHv3] perf tools: add event grouping capability to "perf stat"
Date: Thu, 25 Nov 2010 08:46:31 +0100	[thread overview]
Message-ID: <20101125074629.GC2538@nowhere> (raw)
In-Reply-To: <1290666760.2072.539.camel@laptop>

On Thu, Nov 25, 2010 at 07:32:40AM +0100, Peter Zijlstra wrote:
> On Wed, 2010-11-24 at 17:54 -0800, Corey Ashford wrote:
> > Add the ability to create multiple event groups, each with their own leader
> > using the existing "-e <event>[,<event> ...] [-e <event>[,<event>]]"
> > syntax.  Each additional -e switch creates a new group, and each event
> > listed within a -e switch is within that group.
> > 
> > Changes since v1:
> > - Because of a flub, v2 did not contain the changes I had intended to make,
> > and instead, v2 had the same patch contents as v1.
> > - When perf stat is not supplied any events on the command line, put
> > each default event in its own group.
> 
> I like this, but could you also extend this to perf-record? its a bit
> odd to diverge between the two.
> 
> Using Stephane's latest syntax changes you could actually do something
> like:
> 
> perf record -e task-clock:freq=1000,cycles:period=0

Wouldn't this syntax clash with the flags we have on events already?

the u,k,p flags?




> 
> Which would create a group with 1 sampling counter and a counting
> counter (at which point we should probably start flipping
> PERF_SAMPLE_READ).
> 
> Matt was working on supporting that (although not through cmdline
> syntax) and teaching perf-report to cope with such output.
> 

  reply	other threads:[~2010-11-25  7:46 UTC|newest]

Thread overview: 19+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2010-11-25  1:54 [RFC PATCHv3] perf tools: add event grouping capability to "perf stat" Corey Ashford
2010-11-25  6:32 ` Peter Zijlstra
2010-11-25  7:46   ` Frederic Weisbecker [this message]
2010-11-25  8:00     ` Peter Zijlstra
2010-11-25  8:10       ` Frederic Weisbecker
2010-11-25  9:16     ` Stephane Eranian
2010-11-25 13:19   ` Stephane Eranian
2010-11-25 13:19   ` Stephane Eranian
2010-11-25 13:22     ` Stephane Eranian
2010-11-25 14:02     ` Peter Zijlstra
2010-11-25 14:07       ` Stephane Eranian
2010-11-25 14:12         ` Peter Zijlstra
2010-11-25 14:18           ` Stephane Eranian
2010-11-25 14:22             ` Peter Zijlstra
2010-11-25 15:10               ` Lin Ming
2010-11-25 15:15                 ` Peter Zijlstra
2010-11-25 15:19                   ` Lin Ming
2010-11-25 16:49             ` Arnaldo Carvalho de Melo
2010-11-26 19:22   ` Corey Ashford

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20101125074629.GC2538@nowhere \
    --to=fweisbec@gmail.com \
    --cc=a.p.zijlstra@chello.nl \
    --cc=acme@redhat.com \
    --cc=cjashfor@linux.vnet.ibm.com \
    --cc=eranian@google.com \
    --cc=julia@diku.dk \
    --cc=linux-kernel@vger.kernel.org \
    --cc=matt@console-pimps.org \
    --cc=mingo@elte.hu \
    --cc=paulus@samba.org \
    --cc=tzanussi@gmail.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.