From mboxrd@z Thu Jan 1 00:00:00 1970 From: Olaf Hering Subject: Re: [PATCH] xenalyze: Use types which have consistent sizes across 32- and 64-bit compiles Date: Thu, 25 Nov 2010 12:17:58 +0100 Message-ID: <20101125111758.GA13724@aepfle.de> References: <9b3c5bb22b50106a254d.1290426236@gdunlap-desktop> Mime-Version: 1.0 Content-Type: text/plain; charset=utf-8 Return-path: Content-Disposition: inline In-Reply-To: <9b3c5bb22b50106a254d.1290426236@gdunlap-desktop> List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Sender: xen-devel-bounces@lists.xensource.com Errors-To: xen-devel-bounces@lists.xensource.com To: George Dunlap Cc: xen-devel@lists.xensource.com List-Id: xen-devel@lists.xenproject.org On Mon, Nov 22, George Dunlap wrote: > Always use [unsigned] long long for 64-bit, [unsigned] int for 32-bit. George, there are two unsigned long left in hvm_mmio_assist_process(). I think the sizeof(unsigned long) should be sizeof(unsigned int). Olaf