From: Nick Piggin <npiggin@kernel.dk>
To: Nick Piggin <npiggin@kernel.dk>
Cc: linux-fsdevel@vger.kernel.org, linux-kernel@vger.kernel.org,
linux-ext4@vger.kernel.org, Roman Zippel <zippel@linux-m68k.org>,
"Tigran A. Aivazian" <tigran@aivazian.fsnet.co.uk>,
Boaz Harrosh <bharrosh@panasas.com>,
OGAWA Hirofumi <hirofumi@mail.parknet.co.jp>,
Dave Kleikamp <shaggy@linux.vnet.ibm.com>,
Bob Copeland <me@bobcopeland.com>,
reiserfs-devel@vger.kernel.org,
Christoph Hellwig <hch@infradead.org>,
Evgeniy Dushistov <dushistov@mail.ru>, Jan Kara <jack@suse.cz>
Subject: Re: [RFC][PATCH] Possible data integrity problems in lots of filesystems?
Date: Thu, 25 Nov 2010 22:54:57 +1100 [thread overview]
Message-ID: <20101125115457.GB3643@amd> (raw)
In-Reply-To: <20101125074909.GA4160@amd>
On Thu, Nov 25, 2010 at 06:49:09PM +1100, Nick Piggin wrote:
> Second is confusing sync and async inode metadata writeout
> Core code clears I_DIRTY_SYNC and I_DIRTY_DATASYNC before calling
> ->write_inode *regardless* of whether it is a for-integrity call or
> not. This means background writeback can clear it, and subsequent
> sync_inode_metadata or sync(2) call will skip the next ->write_inode
> completely.
Hmm, this also means that write_inode_now(sync=1) is buggy. It
needs to in fact call ->fsync -- which is a file operation
unfortunately, Christoph didn't you have some patches to move it
into an inode operation?
next prev parent reply other threads:[~2010-11-25 11:54 UTC|newest]
Thread overview: 11+ messages / expand[flat|nested] mbox.gz Atom feed top
2010-11-25 7:49 [RFC][PATCH] Possible data integrity problems in lots of filesystems? Nick Piggin
2010-11-25 9:28 ` Boaz Harrosh
2010-11-25 10:06 ` Nick Piggin
2010-11-25 10:51 ` Boaz Harrosh
2010-11-25 10:52 ` [PATCH] exofs: simple fsync race fix Boaz Harrosh
2010-11-25 11:50 ` Nick Piggin
2011-02-03 11:44 ` Boaz Harrosh
2010-11-25 11:47 ` [RFC][PATCH] Possible data integrity problems in lots of filesystems? Nick Piggin
2010-11-25 12:18 ` Boaz Harrosh
2010-11-25 11:54 ` Nick Piggin [this message]
2010-11-25 12:01 ` Christoph Hellwig
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20101125115457.GB3643@amd \
--to=npiggin@kernel.dk \
--cc=bharrosh@panasas.com \
--cc=dushistov@mail.ru \
--cc=hch@infradead.org \
--cc=hirofumi@mail.parknet.co.jp \
--cc=jack@suse.cz \
--cc=linux-ext4@vger.kernel.org \
--cc=linux-fsdevel@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=me@bobcopeland.com \
--cc=reiserfs-devel@vger.kernel.org \
--cc=shaggy@linux.vnet.ibm.com \
--cc=tigran@aivazian.fsnet.co.uk \
--cc=zippel@linux-m68k.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.