From mboxrd@z Thu Jan  1 00:00:00 1970
Received: from [140.186.70.92] (port=50299 helo=eggs.gnu.org)
	by lists.gnu.org with esmtp (Exim 4.43) id 1PLbCc-00021O-TE
	for qemu-devel@nongnu.org; Thu, 25 Nov 2010 07:45:31 -0500
Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71)
	(envelope-from <paul@codesourcery.com>) id 1PLbCb-0001gW-JC
	for qemu-devel@nongnu.org; Thu, 25 Nov 2010 07:45:30 -0500
Received: from mail.codesourcery.com ([38.113.113.100]:34491)
	by eggs.gnu.org with esmtp (Exim 4.71)
	(envelope-from <paul@codesourcery.com>) id 1PLbCb-0001gJ-9O
	for qemu-devel@nongnu.org; Thu, 25 Nov 2010 07:45:29 -0500
From: Paul Brook <paul@codesourcery.com>
Subject: Re: [Qemu-devel] [PATCH 08/12] ahci: add ahci emulation
Date: Thu, 25 Nov 2010 12:45:18 +0000
References: <1290522889-27559-1-git-send-email-agraf@suse.de>
	<201011251228.45911.paul@codesourcery.com>
	<B0F47AEA-92C1-4FD7-9E3A-707AA73AF26C@suse.de>
In-Reply-To: <B0F47AEA-92C1-4FD7-9E3A-707AA73AF26C@suse.de>
MIME-Version: 1.0
Content-Type: Text/Plain;
  charset="iso-8859-1"
Content-Transfer-Encoding: 7bit
Message-Id: <201011251245.18949.paul@codesourcery.com>
List-Id: qemu-devel.nongnu.org
List-Unsubscribe: <http://lists.nongnu.org/mailman/listinfo/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=unsubscribe>
List-Archive: <http://lists.nongnu.org/archive/html/qemu-devel>
List-Post: <mailto:qemu-devel@nongnu.org>
List-Help: <mailto:qemu-devel-request@nongnu.org?subject=help>
List-Subscribe: <http://lists.nongnu.org/mailman/listinfo/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=subscribe>
To: qemu-devel@nongnu.org
Cc: Kevin Wolf <kwolf@redhat.com>, Joerg Roedel <Joerg.Roedel@amd.com>, Alexander Graf <agraf@suse.de>, Gerd Hoffmann <kraxel@redhat.com>, Stefan Hajnoczi <stefanha@gmail.com>, tj@kernel.org, Roland Elek <elek.roland@gmail.com>, Sebastian Herbszt <herbszt@gmx.de>

> On 25.11.2010, at 13:28, Paul Brook wrote:
> >> Makefile.objs                      |    1 +
> >> default-configs/i386-softmmu.mak   |    1 +
> >> default-configs/x86_64-softmmu.mak |    1 +
> > 
> > Why are you only enabling this on x86?  PCI devices, especially things
> > like SATA controllers, should be completely target independent.
> 
> Because without the mmio series it breaks on big endian devices and we have
> to start somewhere :).

less than half of the targets are big-endian. If it's broken on big-endian 
there should be a comment somewhere documenting this, so we know to fix it.

Paul