From: Arnd Bergmann <arnd@arndb.de>
To: Ian Kent <raven@themaw.net>
Cc: Avi Kivity <avi@redhat.com>,
autofs@linux.kernel.org,
linux-kernel <linux-kernel@vger.kernel.org>
Subject: Re: autofs4 hang in 2.6.37-rc1
Date: Thu, 25 Nov 2010 14:17:51 +0100 [thread overview]
Message-ID: <201011251417.52010.arnd@arndb.de> (raw)
In-Reply-To: <1290052468.2465.7.camel@perseus.themaw.net>
On Thursday 18 November 2010, Ian Kent wrote:
> But the important thing to notice is that the new ioctl interface (in
> fs/autofs4/dev-ioctl.c) used the unlocked_ioctl method since it was
> merged in 2.6.28 and that calls back into the core ioctl code for its
> major functionality. So the core function of the ioctl interface has
> been used without the BKL for quite a while now and has been heavily
> exercised in subsequent testing since the new ioctl interface has been
> in place.
>
> I can't see any reason for keeping the autofs4_ioctl_mutex.
Ok. Are you submitting a patch to remove it? Your reasoning absolutely
makes sense and we need to fix this regression.
Arnd
next prev parent reply other threads:[~2010-11-25 13:17 UTC|newest]
Thread overview: 16+ messages / expand[flat|nested] mbox.gz Atom feed top
2010-11-14 12:55 autofs4 hang in 2.6.37-rc1 Avi Kivity
2010-11-14 13:51 ` Avi Kivity
2010-11-14 15:15 ` Arnd Bergmann
2010-11-14 15:34 ` Avi Kivity
2010-11-15 1:45 ` Ian Kent
2010-11-15 1:45 ` Ian Kent
2010-11-15 8:54 ` Arnd Bergmann
2010-11-15 13:22 ` Ian Kent
2010-11-15 13:27 ` Avi Kivity
2010-11-15 13:38 ` Ian Kent
2010-11-15 13:42 ` Ian Kent
2010-11-18 3:54 ` Ian Kent
2010-11-25 13:17 ` Arnd Bergmann [this message]
2010-11-15 1:31 ` Ian Kent
2010-11-15 9:02 ` Avi Kivity
2010-11-22 8:42 ` Thomas Fjellstrom
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=201011251417.52010.arnd@arndb.de \
--to=arnd@arndb.de \
--cc=autofs@linux.kernel.org \
--cc=avi@redhat.com \
--cc=linux-kernel@vger.kernel.org \
--cc=raven@themaw.net \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.