From: Paul Mundt <lethal@linux-sh.org>
To: linux-sh@vger.kernel.org
Subject: Re: [PATCH] SuperH on-chip EHCI glue
Date: Thu, 25 Nov 2010 15:53:16 +0000 [thread overview]
Message-ID: <20101125155315.GA2053@linux-sh.org> (raw)
In-Reply-To: <20101125080349.GG3270@linux-sh.org>
On Thu, Nov 25, 2010 at 10:46:04AM -0500, Alan Stern wrote:
> On Thu, 25 Nov 2010, Paul Mundt wrote:
> > + .relinquish_port = ehci_relinquish_port,
> > + .port_handed_over = ehci_port_handed_over,
> > +};
>
> You are missing the .endpoint_reset and .ehci_clear_tt_buffer_complete
> members. This is a little surprising -- it implies the driver was
> written by copying another one that didn't have these things, meaning
> it must have been pretty old.
>
I based it on ehci-atmel, which had a similar need for the clock
framework interfacing. I'll add in the two that you noticed, but if I'm
behind on some API changes, is there something else I should be looking
at?
next prev parent reply other threads:[~2010-11-25 15:53 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2010-11-25 8:03 [PATCH] SuperH on-chip EHCI glue Paul Mundt
2010-11-25 15:46 ` Alan Stern
2010-11-25 15:53 ` Paul Mundt [this message]
2010-11-25 16:10 ` Alan Stern
2010-11-29 18:49 ` David Daney
2010-12-01 7:02 ` Paul Mundt
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20101125155315.GA2053@linux-sh.org \
--to=lethal@linux-sh.org \
--cc=linux-sh@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.