From: Olaf Hering <olaf@aepfle.de>
To: Tim Deegan <Tim.Deegan@citrix.com>
Cc: Patrick Colp <pjcolp@cs.ubc.ca>,
"xen-devel@lists.xensource.com" <xen-devel@lists.xensource.com>
Subject: Re: bogus gfn - mfn - gfn - mfn checks in guest_physmap_add_entry
Date: Thu, 25 Nov 2010 21:56:49 +0100 [thread overview]
Message-ID: <20101125205649.GB26720@aepfle.de> (raw)
In-Reply-To: <20101125153216.GJ19638@whitby.uk.xensource.com>
On Thu, Nov 25, Tim Deegan wrote:
> Good catch. It might be better to hook page_set_owner(), which ought to
> imply that the old m2p info is stale. I had a quick look at all its
> callers and I _think_ it would be OK, but I haven't tested that at
> all. :)
I tried page_set_owner().
Blindly adding set_gpfn_from_mfn there leads to compile errors, thanks
to all the redefinitions of mfn_t related macros.
Also, the page_set_owner() in alloc_heap_pages would cause Xen to crash
early.
It appears that maintaing machine_to_phys_mapping[] in
free_domheap_pages() is enough to avoid the ASSERTS.
Olaf
next prev parent reply other threads:[~2010-11-25 20:56 UTC|newest]
Thread overview: 15+ messages / expand[flat|nested] mbox.gz Atom feed top
2010-11-23 21:01 bogus gfn - mfn - gfn - mfn checks in guest_physmap_add_entry Olaf Hering
2010-11-24 10:22 ` Tim Deegan
2010-11-24 10:26 ` Tim Deegan
2010-11-24 14:41 ` Olaf Hering
2010-11-24 14:53 ` Tim Deegan
2010-11-24 15:00 ` Olaf Hering
2010-11-25 15:03 ` Olaf Hering
2010-11-25 15:32 ` Tim Deegan
2010-11-25 20:56 ` Olaf Hering [this message]
2010-11-25 17:16 ` Keir Fraser
2010-11-25 20:53 ` Olaf Hering
2010-11-25 22:30 ` Keir Fraser
2010-11-26 7:27 ` Olaf Hering
2010-11-24 19:58 ` Olaf Hering
2010-11-24 20:25 ` Patrick Colp
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20101125205649.GB26720@aepfle.de \
--to=olaf@aepfle.de \
--cc=Tim.Deegan@citrix.com \
--cc=pjcolp@cs.ubc.ca \
--cc=xen-devel@lists.xensource.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.