From: Paul Mundt <lethal@linux-sh.org>
To: linux-fbdev@vger.kernel.org
Subject: Re: [PATCH 1/2] fbdev: bf537-lq035: new Blackfin Sharp LQ035 framebuffer driver
Date: Fri, 26 Nov 2010 06:09:11 +0000 [thread overview]
Message-ID: <20101126060911.GB7893@linux-sh.org> (raw)
In-Reply-To: <1290591239-6089-1-git-send-email-vapier@gentoo.org>
On Thu, Nov 25, 2010 at 04:21:48AM -0500, Mike Frysinger wrote:
> On Thursday, November 25, 2010 03:28:11 Paul Mundt wrote:
> > On Wed, Nov 24, 2010 at 04:33:58AM -0500, Mike Frysinger wrote:
> > > From: Michael Hennerich <michael.hennerich@analog.com>
> > >
> > > For LCDs hooked up to BF537-STAMP boards.
> > >
> > > Signed-off-by: Michael Hennerich <michael.hennerich@analog.com>
> > > Signed-off-by: Bryan Wu <cooloney@kernel.org>
> > > Signed-off-by: Mike Frysinger <vapier@gentoo.org>
> > > ---
> > > note: these have been posted in the past, but before we got a fbdev
> > >
> > > maintainer, so i'm just reposting them to hopefully get merged
> >
> > On Wed, Nov 24, 2010 at 04:33:59AM -0500, Mike Frysinger wrote:
> > > From: Michael Hennerich <michael.hennerich@analog.com>
> > >
> > > Driver for ADV7393 add-on card for multiple Blackfin boards.
> > >
> > > Signed-off-by: Michael Hennerich <michael.hennerich@analog.com>
> > > Signed-off-by: Bryan Wu <cooloney@kernel.org>
> > > Signed-off-by: Mike Frysinger <vapier@gentoo.org>
> > > ---
> > > note: these have been posted in the past, but before we got a fbdev
> > >
> > > maintainer, so i'm just reposting them to hopefully get merged
> >
> > While I don't really have any strong opinions about these drivers one way
> > or the other, a cursory glance shows that they end up sharing quite a bit
> > of code, along with the existing in-tree blackfin fb drivers. Have you
> > considered trying to abstract things a bit and moving things in to a
> > drivers/video/bfin or the like? Much of the DMA and PPI stuff looks like
> > it could be pretty easily broken out.
>
> we have thought about it quite a bit, but havent quite gotten an answer that
> worked without a lot of cruft
Ok. They're pretty limited in scope anyways, so there's not much harm in
adding them as-is. I've queued them up for .38. I would like to see some
effort to get the blackfin drivers tidied up and a bit more consolidated
in the future, before things get too far out of hand, however.
prev parent reply other threads:[~2010-11-26 6:09 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2010-11-24 9:33 [PATCH 1/2] fbdev: bf537-lq035: new Blackfin Sharp LQ035 framebuffer driver Mike Frysinger
2010-11-25 8:28 ` Paul Mundt
2010-11-25 9:21 ` Mike Frysinger
2010-11-26 6:09 ` Paul Mundt [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20101126060911.GB7893@linux-sh.org \
--to=lethal@linux-sh.org \
--cc=linux-fbdev@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.