From: Olaf Hering <olaf@aepfle.de>
To: xen-devel@lists.xensource.com
Subject: [PATCH 03/21] xenpaging: allow only one xenpaging binary per guest
Date: Fri, 26 Nov 2010 14:49:04 +0100 [thread overview]
Message-ID: <20101126134902.415643948@aepfle.de> (raw)
In-Reply-To: 20101126134901.384130351@aepfle.de
[-- Attachment #1: xen-unstable.xenpaging.xenpaging_init.patch --]
[-- Type: text/plain, Size: 1792 bytes --]
Make sure only one xenpaging binary is active per domain.
Print info when the host lacks the required features for xenpaging.
Signed-off-by: Olaf Hering <olaf@aepfle.de>
Already-Acked-by: Patrick Colp <pjcolp@cs.ubc.ca>
Already-Acked-by: Keir Fraser <keir.fraser@citrix.com>
---
v2: use perror for default case
tools/xenpaging/xenpaging.c | 12 +++++++++++-
xen/arch/x86/mm/mem_event.c | 7 +++++++
2 files changed, 18 insertions(+), 1 deletion(-)
--- xen-unstable.hg-4.1.22433.orig/tools/xenpaging/xenpaging.c
+++ xen-unstable.hg-4.1.22433/tools/xenpaging/xenpaging.c
@@ -123,7 +123,17 @@ xenpaging_t *xenpaging_init(xc_interface
paging->mem_event.ring_page);
if ( rc != 0 )
{
- ERROR("Error initialising shared page");
+ switch ( errno ) {
+ case EBUSY:
+ ERROR("xenpaging is (or was) active on this domain");
+ break;
+ case ENODEV:
+ ERROR("EPT not supported for this guest");
+ break;
+ default:
+ perror("Error initialising shared page");
+ break;
+ }
goto err;
}
--- xen-unstable.hg-4.1.22433.orig/xen/arch/x86/mm/mem_event.c
+++ xen-unstable.hg-4.1.22433/xen/arch/x86/mm/mem_event.c
@@ -214,6 +214,13 @@ int mem_event_domctl(struct domain *d, x
mfn_t ring_mfn;
mfn_t shared_mfn;
+ /* Only one xenpaging at a time. If xenpaging crashed,
+ * the cache is in an undefined state and so is the guest
+ */
+ rc = -EBUSY;
+ if ( d->mem_event.ring_page )
+ break;
+
/* Currently only EPT is supported */
rc = -ENODEV;
if ( !(hap_enabled(d) &&
next prev parent reply other threads:[~2010-11-26 13:49 UTC|newest]
Thread overview: 33+ messages / expand[flat|nested] mbox.gz Atom feed top
2010-11-26 13:49 [PATCH 00/21] xenpaging changes for xen-unstable Olaf Hering
2010-11-26 13:49 ` [PATCH 01/21] xenpaging: break endless loop during inital page-out with large pagefiles Olaf Hering
2010-11-26 13:49 ` [PATCH 02/21] xenpaging: Open paging file only if xenpaging_init() succeeds Olaf Hering
2010-11-26 13:49 ` Olaf Hering [this message]
2010-11-26 13:49 ` [PATCH 04/21] xenpaging: populate paged-out pages unconditionally Olaf Hering
2010-11-26 13:49 ` [PATCH 05/21] xenpaging: add signal handling Olaf Hering
2010-11-26 14:29 ` George Dunlap
2010-12-02 9:59 ` Olaf Hering
2010-12-02 11:48 ` George Dunlap
2010-11-26 13:49 ` [PATCH 06/21] xenpaging: print info when free request slots drop below 2 Olaf Hering
2010-11-26 13:49 ` [PATCH 07/21] xenpaging: print p2mt for already paged-in pages Olaf Hering
2010-11-26 13:49 ` [PATCH 08/21] xenpaging: notify policy only on resume Olaf Hering
2010-11-26 13:49 ` [PATCH 09/21] xenpaging: allow negative num_pages and limit num_pages Olaf Hering
2010-11-26 13:49 ` [PATCH 10/21] xenpaging: when populating a page, check if populating is already in progress Olaf Hering
2010-11-26 13:49 ` [PATCH 11/21] xenpaging: optimize p2m_mem_paging_populate Olaf Hering
2010-11-26 13:49 ` [PATCH 12/21] xenpaging: print xenpaging cmdline options Olaf Hering
2010-11-26 13:49 ` [PATCH 13/21] xenpaging: handle temporary out-of-memory conditions during page-in Olaf Hering
2010-11-26 13:49 ` [PATCH 14/21] xenpaging: increase recently used pages from 4MB to 64MB Olaf Hering
2010-11-26 13:49 ` [PATCH 15/21] xenpaging: update machine_to_phys_mapping during page-in and page deallocation Olaf Hering
2010-11-26 13:49 ` [PATCH 16/21] xenpaging: drop paged pages in guest_remove_page Olaf Hering
2010-11-26 13:49 ` [PATCH 17/21] xenpaging: handle HVMCOPY_gfn_paged_out in copy_from/to_user Olaf Hering
2010-11-26 13:49 ` [PATCH 18/21] xenpaging: prevent page-out of first 16MB Olaf Hering
2010-12-16 16:59 ` Olaf Hering
2010-12-17 9:28 ` Jan Beulich
2010-12-17 12:18 ` Olaf Hering
2010-11-26 13:49 ` [PATCH 19/21] xenpaging: start xenpaging via config option Olaf Hering
2010-11-26 13:49 ` [PATCH 20/21] xenpaging: add dynamic startup delay for xenpaging Olaf Hering
2010-11-26 13:49 ` [PATCH 21/21] xenpaging: (sparse) documenation Olaf Hering
2010-12-07 17:57 ` Ian Jackson
2010-12-07 17:56 ` [PATCH 00/21] xenpaging changes for xen-unstable Ian Jackson
2010-12-07 18:05 ` Keir Fraser
2010-12-07 18:06 ` Keir Fraser
2010-12-07 18:22 ` Ian Jackson
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20101126134902.415643948@aepfle.de \
--to=olaf@aepfle.de \
--cc=xen-devel@lists.xensource.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.