From: Evgeniy Polyakov <zbr@ioremap.net>
To: Nagendra Tomar <tomer_iisc@yahoo.com>
Cc: Eric Dumazet <eric.dumazet@gmail.com>,
netdev@vger.kernel.org, davem@davemloft.net
Subject: Re: [PATCH] net: Fix __inet_inherit_port() to correctly increment bsockets and num_owners
Date: Fri, 26 Nov 2010 18:56:07 +0300 [thread overview]
Message-ID: <20101126155607.GA20022@ioremap.net> (raw)
In-Reply-To: <174335.2288.qm@web53702.mail.re2.yahoo.com>
On Fri, Nov 26, 2010 at 03:20:31AM -0800, Nagendra Tomar (tomer_iisc@yahoo.com) wrote:
> > Frankly I did not find how those optimizations made a bug
> > as well as
> > what is this bug about from given description, but I'm glad
> > it is resolved now :)
> >
>
> I'm not sure of what all went into the "optimization" patch, but the bug is not due to the optimization per-se. As my original post says, it is due to the 'bsockets' and 'num_owners' not being incremented inside __inet_inherit_port(), where it should have been, as __inet_put_port() decrements them on port release, which causes the imbalance.
Argh, I see, thanks a lot for explanation!
--
Evgeniy Polyakov
next prev parent reply other threads:[~2010-11-26 15:56 UTC|newest]
Thread overview: 11+ messages / expand[flat|nested] mbox.gz Atom feed top
2010-11-26 5:09 [PATCH] net: Fix __inet_inherit_port() to correctly increment bsockets and num_owners Nagendra Tomar
2010-11-26 7:20 ` Eric Dumazet
2010-11-26 7:49 ` Nagendra Tomar
2010-11-26 8:23 ` Eric Dumazet
2010-11-26 9:40 ` Nagendra Tomar
2010-11-26 10:47 ` Eric Dumazet
2010-11-26 11:01 ` Nagendra Tomar
2010-11-26 11:07 ` Evgeniy Polyakov
2010-11-26 11:20 ` Nagendra Tomar
2010-11-26 15:56 ` Evgeniy Polyakov [this message]
2010-11-27 0:01 ` [PATCH] net-next: " Nagendra Tomar
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20101126155607.GA20022@ioremap.net \
--to=zbr@ioremap.net \
--cc=davem@davemloft.net \
--cc=eric.dumazet@gmail.com \
--cc=netdev@vger.kernel.org \
--cc=tomer_iisc@yahoo.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.