From: Stefan Richter <stefanr@s5r6.in-berlin.de>
To: Maxim Levitsky <maximlevitsky@gmail.com>
Cc: "netdev@vger.kernel.org" <netdev@vger.kernel.org>,
linux1394-devel <linux1394-devel@lists.sourceforge.net>
Subject: Re: [Q] How to invalidate ARP cache for a network device from within kernel
Date: Sat, 27 Nov 2010 16:19:07 +0100 [thread overview]
Message-ID: <20101127161907.791a3b7c@stein> (raw)
In-Reply-To: <20101127093342.3f1d01ce@stein>
On Nov 27 Stefan Richter wrote:
> > @@ -1593,10 +1593,15 @@ static void fwnet_update(struct fw_unit
> > *unit) {
> > struct fw_device *device = fw_parent_device(unit);
> > struct fwnet_peer *peer = dev_get_drvdata(&unit->device);
> > + struct fwnet_device *dev = peer->dev;
> > int generation;
> >
> > generation = device->generation;
> >
> > + fw_iso_context_stop(dev->broadcast_rcv_context);
> > + fw_iso_context_start(dev->broadcast_rcv_context, -1, 0,
> > + FW_ISO_CONTEXT_MATCH_ALL_TAGS);
[...]
> OTOH, is this actually necessary on normal bus resets? It should only
> be necessary after PM resume, right? If so, perhaps do it only if the
> generation increased by more than one.
Actually, shouldn't context restart at resume happen in firewire-ohci
rather? Any other protocol driver which uses isochronous I/O (be it a
kernel driver or userspace driver) would have the same issue, I guess.
--
Stefan Richter
-=====-==-=- =-== ==-==
http://arcgraph.de/sr/
next prev parent reply other threads:[~2010-11-27 15:19 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2010-11-26 17:38 [Q] How to invalidate ARP cache for a network device from within kernel Maxim Levitsky
2010-11-27 1:18 ` Stefan Richter
2010-11-27 1:25 ` Maxim Levitsky
2010-11-27 8:33 ` Stefan Richter
2010-11-27 15:19 ` Stefan Richter [this message]
2010-11-27 15:44 ` Maxim Levitsky
2010-11-27 14:13 ` Stefan Richter
2010-11-27 14:33 ` Maxim Levitsky
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20101127161907.791a3b7c@stein \
--to=stefanr@s5r6.in-berlin.de \
--cc=linux1394-devel@lists.sourceforge.net \
--cc=maximlevitsky@gmail.com \
--cc=netdev@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.