From mboxrd@z Thu Jan 1 00:00:00 1970 From: "Michael S. Tsirkin" Subject: Re: [PATCH 15/21] virtio-net: replace qemu_sendv_packet_async() with qemu_sendv_packet_async_proxy(). Date: Sun, 28 Nov 2010 11:31:02 +0200 Message-ID: <20101128093102.GB3342@redhat.com> References: <1290665220-26478-1-git-send-email-tamura.yoshiaki@lab.ntt.co.jp> <1290665220-26478-16-git-send-email-tamura.yoshiaki@lab.ntt.co.jp> Mime-Version: 1.0 Content-Type: text/plain; charset=us-ascii Cc: kvm@vger.kernel.org, qemu-devel@nongnu.org, avi@redhat.com, anthony@codemonkey.ws, aliguori@us.ibm.com, mtosatti@redhat.com, dlaor@redhat.com, ananth@in.ibm.com, psuriset@linux.vnet.ibm.com, vatsa@linux.vnet.ibm.com, stefanha@linux.vnet.ibm.com, ohmura.kei@lab.ntt.co.jp To: Yoshiaki Tamura Return-path: Received: from mx1.redhat.com ([209.132.183.28]:50730 "EHLO mx1.redhat.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751927Ab0K1Jbq (ORCPT ); Sun, 28 Nov 2010 04:31:46 -0500 Content-Disposition: inline In-Reply-To: <1290665220-26478-16-git-send-email-tamura.yoshiaki@lab.ntt.co.jp> Sender: kvm-owner@vger.kernel.org List-ID: On Thu, Nov 25, 2010 at 03:06:54PM +0900, Yoshiaki Tamura wrote: > Replace replace qemu_sendv_packet_async() with > qemu_sendv_packet_async_proxy() to let event-tap capture events from > virtio-net. > > Signed-off-by: Yoshiaki Tamura Why does every device need to know about eent tap? Can qemu_sendv_packet_async just do the right thing instead? > --- > hw/virtio-net.c | 4 ++-- > 1 files changed, 2 insertions(+), 2 deletions(-) > > diff --git a/hw/virtio-net.c b/hw/virtio-net.c > index 1d61f19..8c76346 100644 > --- a/hw/virtio-net.c > +++ b/hw/virtio-net.c > @@ -710,8 +710,8 @@ static int32_t virtio_net_flush_tx(VirtIONet *n, VirtQueue *vq) > len += hdr_len; > } > > - ret = qemu_sendv_packet_async(&n->nic->nc, out_sg, out_num, > - virtio_net_tx_complete); > + ret = qemu_sendv_packet_async_proxy(&n->nic->nc, out_sg, out_num, > + virtio_net_tx_complete); > if (ret == 0) { > virtio_queue_set_notification(n->tx_vq, 0); > n->async_tx.elem = elem; > -- > 1.7.1.2 > > -- > To unsubscribe from this list: send the line "unsubscribe kvm" in > the body of a message to majordomo@vger.kernel.org > More majordomo info at http://vger.kernel.org/majordomo-info.html From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from [140.186.70.92] (port=34861 helo=eggs.gnu.org) by lists.gnu.org with esmtp (Exim 4.43) id 1PMdbn-0006Oe-8E for qemu-devel@nongnu.org; Sun, 28 Nov 2010 04:31:48 -0500 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1PMdbm-0004eL-0q for qemu-devel@nongnu.org; Sun, 28 Nov 2010 04:31:47 -0500 Received: from mx1.redhat.com ([209.132.183.28]:56911) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1PMdbl-0004eG-OT for qemu-devel@nongnu.org; Sun, 28 Nov 2010 04:31:45 -0500 Date: Sun, 28 Nov 2010 11:31:02 +0200 From: "Michael S. Tsirkin" Message-ID: <20101128093102.GB3342@redhat.com> References: <1290665220-26478-1-git-send-email-tamura.yoshiaki@lab.ntt.co.jp> <1290665220-26478-16-git-send-email-tamura.yoshiaki@lab.ntt.co.jp> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <1290665220-26478-16-git-send-email-tamura.yoshiaki@lab.ntt.co.jp> Subject: [Qemu-devel] Re: [PATCH 15/21] virtio-net: replace qemu_sendv_packet_async() with qemu_sendv_packet_async_proxy(). List-Id: qemu-devel.nongnu.org List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: Yoshiaki Tamura Cc: aliguori@us.ibm.com, dlaor@redhat.com, ananth@in.ibm.com, kvm@vger.kernel.org, ohmura.kei@lab.ntt.co.jp, mtosatti@redhat.com, qemu-devel@nongnu.org, vatsa@linux.vnet.ibm.com, avi@redhat.com, psuriset@linux.vnet.ibm.com, stefanha@linux.vnet.ibm.com On Thu, Nov 25, 2010 at 03:06:54PM +0900, Yoshiaki Tamura wrote: > Replace replace qemu_sendv_packet_async() with > qemu_sendv_packet_async_proxy() to let event-tap capture events from > virtio-net. > > Signed-off-by: Yoshiaki Tamura Why does every device need to know about eent tap? Can qemu_sendv_packet_async just do the right thing instead? > --- > hw/virtio-net.c | 4 ++-- > 1 files changed, 2 insertions(+), 2 deletions(-) > > diff --git a/hw/virtio-net.c b/hw/virtio-net.c > index 1d61f19..8c76346 100644 > --- a/hw/virtio-net.c > +++ b/hw/virtio-net.c > @@ -710,8 +710,8 @@ static int32_t virtio_net_flush_tx(VirtIONet *n, VirtQueue *vq) > len += hdr_len; > } > > - ret = qemu_sendv_packet_async(&n->nic->nc, out_sg, out_num, > - virtio_net_tx_complete); > + ret = qemu_sendv_packet_async_proxy(&n->nic->nc, out_sg, out_num, > + virtio_net_tx_complete); > if (ret == 0) { > virtio_queue_set_notification(n->tx_vq, 0); > n->async_tx.elem = elem; > -- > 1.7.1.2 > > -- > To unsubscribe from this list: send the line "unsubscribe kvm" in > the body of a message to majordomo@vger.kernel.org > More majordomo info at http://vger.kernel.org/majordomo-info.html