From: Andy Whitcroft <apw@canonical.com>
To: Miklos Szeredi <miklos@szeredi.hu>
Cc: linux-fsdevel@vger.kernel.org, linux-kernel@vger.kernel.org,
vaurora@redhat.com, neilb@suse.de, viro@zeniv.linux.org.uk
Subject: Re: [PATCH 0/2] overlayfs fixes
Date: Sun, 28 Nov 2010 19:18:14 +0000 [thread overview]
Message-ID: <20101128191813.GC11339@shadowen.org> (raw)
In-Reply-To: <E1PLdPT-0003Y7-31@pomaz-ex.szeredi.hu>
On Thu, Nov 25, 2010 at 04:06:55PM +0100, Miklos Szeredi wrote:
> On Wed, 17 Nov 2010, Andy Whitcroft wrote:
> > overlayfs: handle missing lower inodes in ovl_is_same_inode
>
> I don't see how this could be needed. vfs_is_same_inode() checks if
> the dentries are positive. In that case either the upper dentry or
> the lower dentry or both must exist.
It was cirtinaly exploding in my tests without that change. The test
case was overlaying a tmpfs over a squashfs.
> > overlayfs: ovl_copy_up_xattr -- handle EOPNOTSUPP from vfs_listxattr
>
> Applied. Thanks, Andy.
>
> I pushed an updated version based on v2.6.37-rc3 to the overlayfs.v5
> branch:
>
> git://git.kernel.org/pub/scm/linux/kernel/git/mszeredi/vfs.git overlayfs.v5
>
> Thanks,
> Miklos
I'll retest with that version and see if the first patch is still
required.
Thanks for the updated version.
-apw
prev parent reply other threads:[~2010-11-28 19:18 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2010-11-17 17:37 [PATCH 0/2] overlayfs fixes Andy Whitcroft
2010-11-17 17:37 ` [PATCH 1/2] overlayfs: handle missing lower inodes in ovl_is_same_inode Andy Whitcroft
2010-11-17 17:37 ` [PATCH 2/2] overlayfs: ovl_copy_up_xattr -- handle EOPNOTSUPP from vfs_listxattr Andy Whitcroft
2010-11-25 15:06 ` [PATCH 0/2] overlayfs fixes Miklos Szeredi
2010-11-28 19:18 ` Andy Whitcroft [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20101128191813.GC11339@shadowen.org \
--to=apw@canonical.com \
--cc=linux-fsdevel@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=miklos@szeredi.hu \
--cc=neilb@suse.de \
--cc=vaurora@redhat.com \
--cc=viro@zeniv.linux.org.uk \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.