From mboxrd@z Thu Jan 1 00:00:00 1970 From: Zhenyu Wang Subject: piglit regression on sandybridge Date: Mon, 29 Nov 2010 16:52:32 +0800 Message-ID: <20101129085232.GA4900@zhen-devel.sh.intel.com> Reply-To: Zhenyu Wang Mime-Version: 1.0 Content-Type: multipart/mixed; boundary="===============0679042262==" Return-path: Received: from mga09.intel.com (mga09.intel.com [134.134.136.24]) by gabe.freedesktop.org (Postfix) with ESMTP id 783DA9E78C for ; Mon, 29 Nov 2010 00:52:34 -0800 (PST) List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: intel-gfx-bounces+gcfxdi-intel-gfx=m.gmane.org@lists.freedesktop.org Errors-To: intel-gfx-bounces+gcfxdi-intel-gfx=m.gmane.org@lists.freedesktop.org To: Eric Anholt Cc: intel-gfx List-Id: intel-gfx@lists.freedesktop.org --===============0679042262== Content-Type: multipart/signed; micalg=pgp-sha1; protocol="application/pgp-signature"; boundary="tKW2IUtsqtDRztdT" Content-Disposition: inline --tKW2IUtsqtDRztdT Content-Type: text/plain; charset=us-ascii Content-Disposition: inline Content-Transfer-Encoding: quoted-printable Eric, Looks the culprit for recent piglit regression on sandybridge that caused hang is bisected to commit 9effc1adf1e7ba57fb3b10909762b76c1ae12f61 Author: Eric Anholt Date: Mon Oct 11 16:02:08 2010 -0700 i965: re-enable gen6 IF statements in the fragment shader. IF statements were getting flattened while they were broken. With Zhenyu's last fix for ENDIF's type, everything appears to have lined up to actually work. This regresses two tests: glsl1-! (not) operator (1, fail) glsl1-! (not) operator (1, pass) but fixes tests that couldn't work before because the IFs couldn't be flattened: glsl-fs-discard-01 occlusion-query-discard (and, naturally, this should be a performance improvement for apps that actually use IF statements to avoid executing a bunch of code). What may go wrong with this? QA is stalled on this to continue on running piglit.. thanks. --=20 Open Source Technology Center, Intel ltd. $gpg --keyserver wwwkeys.pgp.net --recv-keys 4D781827 --tKW2IUtsqtDRztdT Content-Type: application/pgp-signature; name="signature.asc" Content-Description: Digital signature Content-Disposition: inline -----BEGIN PGP SIGNATURE----- Version: GnuPG v1.4.10 (GNU/Linux) iEYEARECAAYFAkzzadAACgkQsQQaM014GCd98ACcD7zg97oOR/8mKVmS1aWTTTwp kuYAoJ1QVoIb9BXpP1qF7w//UqIt+NXv =R8SB -----END PGP SIGNATURE----- --tKW2IUtsqtDRztdT-- --===============0679042262== Content-Type: text/plain; charset="us-ascii" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit Content-Disposition: inline _______________________________________________ Intel-gfx mailing list Intel-gfx@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/intel-gfx --===============0679042262==--