From mboxrd@z Thu Jan 1 00:00:00 1970 From: Vasily Khoruzhick Subject: Re: [PATCH v3] ARM: s3c2442: Setup gpio {set,get}_pull callbacks Date: Mon, 29 Nov 2010 11:56:09 +0200 Message-ID: <201011291156.09784.anarsoul@gmail.com> References: <1289030074-5233-1-git-send-email-anarsoul@gmail.com> <1289247983-20747-1-git-send-email-anarsoul@gmail.com> Mime-Version: 1.0 Content-Type: Text/Plain; charset="utf-8" Content-Transfer-Encoding: 7bit Return-path: Received: from mail-ew0-f46.google.com ([209.85.215.46]:45598 "EHLO mail-ew0-f46.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751591Ab0K2J4j (ORCPT ); Mon, 29 Nov 2010 04:56:39 -0500 Received: by ewy5 with SMTP id 5so1798354ewy.19 for ; Mon, 29 Nov 2010 01:56:38 -0800 (PST) In-Reply-To: <1289247983-20747-1-git-send-email-anarsoul@gmail.com> Sender: linux-samsung-soc-owner@vger.kernel.org List-Id: linux-samsung-soc@vger.kernel.org To: Ben Dooks , Russell King , Kukjin Kim Cc: Lars-Peter Clausen , linux-samsung-soc@vger.kernel.org, linux-arm-kernel@lists.infradead.org, Abdoulaye Walsimou GAYE On Monday 08 November 2010 22:26:23 Vasily Khoruzhick wrote: > Currently the {set,get}_pull callbacks of the s3c24xx_gpiocfg_default > structure are initalized via s3c_gpio_{get,set}pull_1up. This results in a > linker error when compiling kernel for s3c2442: > > arch/arm/plat-s3c24xx/built-in.o:(.data+0x13f4): undefined reference to > `s3c_gpio_getpull_1up' > arch/arm/plat-s3c24xx/built-in.o:(.data+0x13f8): undefined reference to > `s3c_gpio_setpull_1up' > > The s3c2442 has pulldowns instead of pullups compared to the s3c2440. > The method of controlling them is the same though. > So this patch modifies the existing s3c_gpio_{get,set}pull_1up helper > functions to take an additional parameter deciding whether the pin has a > pullup or pulldown. The s3c_gpio_{get,set}pull_1{down,up} functions then > wrap that functions passing either S3C_GPIO_PULL_UP or S3C_GPIO_PULL_DOWN. > > Furthermore this patch sets up the s3c24xx_gpiocfg_default.{get,set}_pull > fields in the s3c2442 cpu init function to the new pulldown helper > functions. > > Based on patch from "Lars-Peter Clausen" Hi there, Can any samsung-soc maintainer review/merge this patch? I should admit that merging patches through samsung maintainers became pretty impossible - response latency is about 1 month, some patches (not mine) are still pending. I've sent first version of this patch on 6th of November, few weeks of standby - and we'll get 2.6.37 with broken s3c2442 support. Yeah, I know that maintainers are living people too, and they need to pay attention to real life, work, family, etc, but now merging some samsung-soc-related patch is really painfull and slow proccess, and it would be nice if it could be somehow improved. Regards Vasily From mboxrd@z Thu Jan 1 00:00:00 1970 From: anarsoul@gmail.com (Vasily Khoruzhick) Date: Mon, 29 Nov 2010 11:56:09 +0200 Subject: [PATCH v3] ARM: s3c2442: Setup gpio {set,get}_pull callbacks In-Reply-To: <1289247983-20747-1-git-send-email-anarsoul@gmail.com> References: <1289030074-5233-1-git-send-email-anarsoul@gmail.com> <1289247983-20747-1-git-send-email-anarsoul@gmail.com> Message-ID: <201011291156.09784.anarsoul@gmail.com> To: linux-arm-kernel@lists.infradead.org List-Id: linux-arm-kernel.lists.infradead.org On Monday 08 November 2010 22:26:23 Vasily Khoruzhick wrote: > Currently the {set,get}_pull callbacks of the s3c24xx_gpiocfg_default > structure are initalized via s3c_gpio_{get,set}pull_1up. This results in a > linker error when compiling kernel for s3c2442: > > arch/arm/plat-s3c24xx/built-in.o:(.data+0x13f4): undefined reference to > `s3c_gpio_getpull_1up' > arch/arm/plat-s3c24xx/built-in.o:(.data+0x13f8): undefined reference to > `s3c_gpio_setpull_1up' > > The s3c2442 has pulldowns instead of pullups compared to the s3c2440. > The method of controlling them is the same though. > So this patch modifies the existing s3c_gpio_{get,set}pull_1up helper > functions to take an additional parameter deciding whether the pin has a > pullup or pulldown. The s3c_gpio_{get,set}pull_1{down,up} functions then > wrap that functions passing either S3C_GPIO_PULL_UP or S3C_GPIO_PULL_DOWN. > > Furthermore this patch sets up the s3c24xx_gpiocfg_default.{get,set}_pull > fields in the s3c2442 cpu init function to the new pulldown helper > functions. > > Based on patch from "Lars-Peter Clausen" Hi there, Can any samsung-soc maintainer review/merge this patch? I should admit that merging patches through samsung maintainers became pretty impossible - response latency is about 1 month, some patches (not mine) are still pending. I've sent first version of this patch on 6th of November, few weeks of standby - and we'll get 2.6.37 with broken s3c2442 support. Yeah, I know that maintainers are living people too, and they need to pay attention to real life, work, family, etc, but now merging some samsung-soc-related patch is really painfull and slow proccess, and it would be nice if it could be somehow improved. Regards Vasily