From mboxrd@z Thu Jan  1 00:00:00 1970
From: Wei Wang2 <wei.wang2@amd.com>
Subject: Re: [PATCH] hvm passthru: Fix a xen-unstable crash
Date: Mon, 29 Nov 2010 17:47:09 +0100
Message-ID: <201011291747.09794.wei.wang2@amd.com>
References: <C9196DCE.B449%keir@xen.org>
	<alpine.DEB.2.00.1011291547230.14723@kaball-desktop>
Mime-Version: 1.0
Content-Type: text/plain; charset="iso-8859-1"
Content-Transfer-Encoding: 7bit
Return-path: <xen-devel-bounces@lists.xensource.com>
In-Reply-To: <alpine.DEB.2.00.1011291547230.14723@kaball-desktop>
Content-Disposition: inline
List-Unsubscribe: <http://lists.xensource.com/mailman/listinfo/xen-devel>,
	<mailto:xen-devel-request@lists.xensource.com?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xensource.com>
List-Help: <mailto:xen-devel-request@lists.xensource.com?subject=help>
List-Subscribe: <http://lists.xensource.com/mailman/listinfo/xen-devel>,
	<mailto:xen-devel-request@lists.xensource.com?subject=subscribe>
Sender: xen-devel-bounces@lists.xensource.com
Errors-To: xen-devel-bounces@lists.xensource.com
To: Stefano Stabellini <stefano.stabellini@eu.citrix.com>
Cc: "xen-devel@lists.xensource.com" <xen-devel@lists.xensource.com>, Keir Fraser <keir@xen.org>
List-Id: xen-devel@lists.xenproject.org

On Monday 29 November 2010 16:49:05 Stefano Stabellini wrote:
> On Mon, 29 Nov 2010, Keir Fraser wrote:
> > Stefano,
> >
> > Can you ack/nack this patch please.
>
> ack.
>
> I think we also need this:
>
>
> diff -r 79b71c77907b xen/arch/x86/physdev.c
> --- a/xen/arch/x86/physdev.c	Wed Nov 24 10:20:03 2010 +0000
> +++ b/xen/arch/x86/physdev.c	Mon Nov 29 15:26:03 2010 +0000
> @@ -236,7 +236,8 @@ static int physdev_unmap_pirq(struct phy
>          spin_lock(&d->event_lock);
>          ret = unmap_domain_pirq_emuirq(d, unmap->pirq);
>          spin_unlock(&d->event_lock);
> -        goto free_domain;
> +        if ( unmap->domid == DOMID_SELF || ret )
> +            goto free_domain;
>      }
>
>      ret = -EPERM;
>
>
> Wei, could you give it a try, in addition to your patch?
>
> Thanks,
>
> Stefano

Hi Stefano,
This patch works well together with my patch on our testing system. No more 
crashes.
Thanks,
Wei