All of lore.kernel.org
 help / color / mirror / Atom feed
From: "John W. Linville" <linville@tuxdriver.com>
To: David Kilroy <kilroyd@gmail.com>
Cc: linux-wireless@vger.kernel.org, comes@naic.edu,
	David Kilroy <kilroyd@googlemail.com>
Subject: Re: [PATCH] orinoco: abort scan on interface down
Date: Mon, 29 Nov 2010 14:26:29 -0500	[thread overview]
Message-ID: <20101129192628.GC8199@tuxdriver.com> (raw)
In-Reply-To: <1290630782-11095-1-git-send-email-kilroyd@googlemail.com>

On Wed, Nov 24, 2010 at 08:33:02PM +0000, David Kilroy wrote:
> This fixes the problem causing the following trace:
> 
> ------------[ cut here ]------------
> WARNING: at linux-2.6.34/net/wireless/core.c:633 wdev_cleanup_work+0xb7/0xe0 [cfg80211]()
> Hardware name: Latitude C840
> Pid: 707, comm: cfg80211 Not tainted 2.6.34.7-0.5-desktop #1
> Call Trace:
>  [<c02065c3>] try_stack_unwind+0x173/0x190
>  [<c02051cf>] dump_trace+0x3f/0xe0
>  [<c020662b>] show_trace_log_lvl+0x4b/0x60
>  [<c0206658>] show_trace+0x18/0x20
>  [<c064e0b3>] dump_stack+0x6d/0x72
>  [<c02443ae>] warn_slowpath_common+0x6e/0xb0
>  [<c0244403>] warn_slowpath_null+0x13/0x20
>  [<e2db5497>] wdev_cleanup_work+0xb7/0xe0 [cfg80211]
>  [<c025cfa9>] run_workqueue+0x79/0x170
>  [<c025d123>] worker_thread+0x83/0xe0
>  [<c025fef4>] kthread+0x74/0x80
>  [<c0203826>] kernel_thread_helper+0x6/0x10
> ---[ end trace 3f0348b3b0c6f4ff ]---
> 
> Reported by: Giacomo Comes <comes@naic.edu>
> Signed-off-by: David Kilroy <kilroyd@googlemail.com>
> ---
> 
> This patch has only been compile tested. Given the trace, I've
> guessed that cfg80211 would prefer that orinoco abort the scan on
> interface down.

Any chance we can get a Tested-by on this one, so I can feel good
about sending it for 2.6.37?

John
-- 
John W. Linville		Someday the world will need a hero, and you
linville@tuxdriver.com			might be all we have.  Be ready.

  reply	other threads:[~2010-11-29 19:29 UTC|newest]

Thread overview: 5+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2010-11-24 20:33 [PATCH] orinoco: abort scan on interface down David Kilroy
2010-11-29 19:26 ` John W. Linville [this message]
2010-11-29 20:18   ` Sedat Dilek
2010-11-30  2:23     ` Giacomo Comes
2010-12-01 22:52       ` Dave Kilroy

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20101129192628.GC8199@tuxdriver.com \
    --to=linville@tuxdriver.com \
    --cc=comes@naic.edu \
    --cc=kilroyd@gmail.com \
    --cc=kilroyd@googlemail.com \
    --cc=linux-wireless@vger.kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.