From: Greg KH <greg@kroah.com>
To: Marek Belisko <marek.belisko@open-nandra.com>
Cc: Greg Kroah-Hartman <gregkh@suse.de>,
devel@driverdev.osuosl.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH 4/6] staging: ft1000: Remove unused headers.
Date: Mon, 29 Nov 2010 11:43:22 -0800 [thread overview]
Message-ID: <20101129194322.GA14086@kroah.com> (raw)
In-Reply-To: <1290515373-16145-5-git-send-email-marek.belisko@open-nandra.com>
On Tue, Nov 23, 2010 at 01:29:31PM +0100, Marek Belisko wrote:
> Signed-off-by: Marek Belisko <marek.belisko@open-nandra.com>
> ---
> drivers/staging/ft1000/ft1000-usb/ft1000_chdev.c | 9 ---------
> 1 files changed, 0 insertions(+), 9 deletions(-)
>
> diff --git a/drivers/staging/ft1000/ft1000-usb/ft1000_chdev.c b/drivers/staging/ft1000/ft1000-usb/ft1000_chdev.c
> index 8d2c059..3df4b4c 100644
> --- a/drivers/staging/ft1000/ft1000-usb/ft1000_chdev.c
> +++ b/drivers/staging/ft1000/ft1000-usb/ft1000_chdev.c
> @@ -24,23 +24,14 @@
> // 6/05/06 Whc Porting to Linux 2.6.9
> //
> //---------------------------------------------------------------------------
> -#include <linux/module.h>
> -#include <linux/kernel.h>
> #include <linux/sched.h>
Odds are you do want module.h and kernel.h but not sched.h, right?
> -#include <linux/signal.h>
> -#include <linux/errno.h>
You have no error numbers in this driver? I doubt that.
> #include <linux/poll.h>
> #include <linux/netdevice.h>
> #include <linux/delay.h>
> #include <linux/miscdevice.h>
> -
> -#include <linux/fs.h>
> -#include <linux/kmod.h>
These can be removed.
> #include <linux/ioctl.h>
> -#include <linux/unistd.h>
As can this.
thanks,
greg k-h
next prev parent reply other threads:[~2010-11-29 19:46 UTC|newest]
Thread overview: 17+ messages / expand[flat|nested] mbox.gz Atom feed top
2010-11-23 12:29 [PATCH 0/6] Add misc device handling Marek Belisko
2010-11-23 12:29 ` [PATCH 1/6] staging: ft1000: Remove functions which create devices in kernel space Marek Belisko
2010-11-23 12:29 ` [PATCH 2/6] staging: ft1000: Use misc device instead self created device Marek Belisko
2010-11-23 13:53 ` Jiri Slaby
2010-11-23 14:00 ` Belisko Marek
2010-11-23 21:28 ` Jiri Slaby
2010-11-24 9:16 ` Belisko Marek
2010-11-29 19:44 ` Greg KH
2010-11-29 20:08 ` Belisko Marek
2010-12-01 4:06 ` Greg KH
2010-12-01 9:35 ` Belisko Marek
2010-11-23 12:29 ` [PATCH 3/6] staging: ft1000: Remove unused variables Marek Belisko
2010-11-23 12:29 ` [PATCH 4/6] staging: ft1000: Remove unused headers Marek Belisko
2010-11-29 19:43 ` Greg KH [this message]
2010-11-23 12:29 ` [PATCH 5/6] staging: ft1000: Remove dead code Marek Belisko
2010-11-23 12:29 ` [PATCH 6/6] staging: ft1000: Check return value of ft1000_CreateDevice() Marek Belisko
2010-11-29 19:44 ` [PATCH 0/6] Add misc device handling Greg KH
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20101129194322.GA14086@kroah.com \
--to=greg@kroah.com \
--cc=devel@driverdev.osuosl.org \
--cc=gregkh@suse.de \
--cc=linux-kernel@vger.kernel.org \
--cc=marek.belisko@open-nandra.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.