From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from [140.186.70.92] (port=55272 helo=eggs.gnu.org) by lists.gnu.org with esmtp (Exim 4.43) id 1PNADm-0001JU-9m for qemu-devel@nongnu.org; Mon, 29 Nov 2010 15:21:11 -0500 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1PNADj-00069e-Q4 for qemu-devel@nongnu.org; Mon, 29 Nov 2010 15:21:10 -0500 Received: from mail.codesourcery.com ([38.113.113.100]:47467) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1PNADj-00069J-Hh for qemu-devel@nongnu.org; Mon, 29 Nov 2010 15:21:07 -0500 Date: Mon, 29 Nov 2010 12:21:05 -0800 From: Nathan Froyd Subject: Re: [Qemu-devel] [PATCH 08/12] ARM: Return correct result for single<->double conversion of NaN Message-ID: <20101129202105.GQ8544@codesourcery.com> References: <1290538431-13170-1-git-send-email-peter.maydell@linaro.org> <1290538431-13170-9-git-send-email-peter.maydell@linaro.org> <20101129174928.GE8544@codesourcery.com> <20101129195453.GP8544@codesourcery.com> MIME-Version: 1.0 Content-Type: text/plain; charset=iso-8859-1 Content-Disposition: inline Content-Transfer-Encoding: 8bit In-Reply-To: List-Id: qemu-devel.nongnu.org List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: Peter Maydell Cc: qemu-devel@nongnu.org On Mon, Nov 29, 2010 at 08:04:42PM +0000, Peter Maydell wrote: > On 29 November 2010 19:54, Nathan Froyd wrote: > > On Mon, Nov 29, 2010 at 07:25:18PM +0000, Peter Maydell wrote: > >> (b) add to and extend the softfloat API whenever you have some > >> floating-point related thing it doesn't currently support > > > > I think this is the best approach whenever possible. > > OK. Do we care about maintaining consistency of the API between > softfloat and softfloat-native (the latter used only on x86, x86_64, > cris, sh4, sh4eb)? softfloat-native should just go away. I would not worry about API compatibility between native and non-native configurations there. > >> (c) do something suboptimal where the softfloat API provides > >> some-API-but-not-quite-the-ideal-API (which I'm not particularly > >> keen on and is what I see the "is_nan() || is_signalling_nan()" > >> approach as) > > > > Yes, this is ugly.  Are you up for running: > > > >  perl -p -i -e 's/float(\d+)_is_nan/float\1_is_quiet_nan/g' target-*/*.c > > > > (and also carefully in fpu/*) or similar and moving the bit-twiddling > > float_is_nan into fpu/? > > I'm happy to produce a patch doing that if it will be committed :-) Well, I can't promise the committal part... :) -Nathan