All of lore.kernel.org
 help / color / mirror / Atom feed
From: Greg KH <greg@kroah.com>
To: Jiri Slaby <jslaby@suse.cz>
Cc: gregkh@suse.de, slapin@ossfans.org, linux-kernel@vger.kernel.org,
	jirislaby@gmail.com, Alan Cox <alan@linux.intel.com>
Subject: Re: [PATCH 1/2] TTY: ldisc, fix open flag handling
Date: Mon, 29 Nov 2010 13:50:30 -0800	[thread overview]
Message-ID: <20101129215030.GC9830@kroah.com> (raw)
In-Reply-To: <1290641275-21726-1-git-send-email-jslaby@suse.cz>

On Thu, Nov 25, 2010 at 12:27:54AM +0100, Jiri Slaby wrote:
> When a concrete ldisc open fails in tty_ldisc_open, we forget to clear
> TTY_LDISC_OPEN. This causes a false warning on the next ldisc open:
> WARNING: at drivers/char/tty_ldisc.c:445 tty_ldisc_open+0x26/0x38()
> Hardware name: System Product Name
> Modules linked in: ...
> Pid: 5251, comm: a.out Tainted: G        W  2.6.32-5-686 #1
> Call Trace:
>  [<c1030321>] ? warn_slowpath_common+0x5e/0x8a
>  [<c1030357>] ? warn_slowpath_null+0xa/0xc
>  [<c119311c>] ? tty_ldisc_open+0x26/0x38
>  [<c11936c5>] ? tty_set_ldisc+0x218/0x304
> ...
> 
> So clear the bit when failing...
> 
> Introduced in c65c9bc3efa (tty: rewrite the ldisc locking) back in
> 2.6.31-rc1.
> 
> Signed-off-by: Jiri Slaby <jslaby@suse.cz>
> Cc: Alan Cox <alan@linux.intel.com>
> Reported-by: Sergey Lapin <slapin@ossfans.org>
> Tested-by: Sergey Lapin <slapin@ossfans.org>

Is this still needed, or can I just use your:
	[PATCH v2 1/2] TTY: don't allow reopen when ldisc is changing
patch instead?

thanks,

greg k-h

  reply	other threads:[~2010-11-29 21:50 UTC|newest]

Thread overview: 16+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2010-11-24 13:52 ldisc problems with 2.6.32-2.6.37-rc2 (at least) Sergey Lapin
2010-11-24 14:33 ` Jiri Slaby
2010-11-24 17:03   ` Sergey Lapin
2010-11-24 19:43     ` Jiri Slaby
2010-11-24 19:45       ` Jiri Slaby
2010-11-24 21:53         ` Sergey Lapin
2010-11-24 22:02           ` Jiri Slaby
2010-11-24 22:26             ` Sergey Lapin
2010-11-24 22:41               ` Jiri Slaby
2010-11-24 23:27                 ` [PATCH 1/2] TTY: ldisc, fix open flag handling Jiri Slaby
2010-11-29 21:50                   ` Greg KH [this message]
2010-11-29 22:41                     ` Jiri Slaby
2010-11-29 22:47                       ` Greg KH
2010-11-24 23:27                 ` [PATCH 2/2] NET: wan/x25, fix ldisc->open retval Jiri Slaby
2010-11-25 23:13                   ` Sergey Lapin
2010-11-24 22:03         ` ldisc problems with 2.6.32-2.6.37-rc2 (at least) Sergey Lapin

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20101129215030.GC9830@kroah.com \
    --to=greg@kroah.com \
    --cc=alan@linux.intel.com \
    --cc=gregkh@suse.de \
    --cc=jirislaby@gmail.com \
    --cc=jslaby@suse.cz \
    --cc=linux-kernel@vger.kernel.org \
    --cc=slapin@ossfans.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.