From: Mark Brown <broonie@opensource.wolfsonmicro.com>
To: Joe Perches <joe@perches.com>
Cc: Liam Girdwood <lrg@slimlogic.co.uk>, linux-kernel@vger.kernel.org
Subject: Re: [PATCH] regulator: Add and use rdev_<level> macros
Date: Mon, 29 Nov 2010 22:00:46 +0000 [thread overview]
Message-ID: <20101129220046.GB8335@opensource.wolfsonmicro.com> (raw)
In-Reply-To: <9c7b69e9a5274587e5ba9f2b460f79f0159e9b75.1291060462.git.joe@perches.com>
On Mon, Nov 29, 2010 at 11:54:50AM -0800, Joe Perches wrote:
> +#define rdev_debug(rdev, fmt, ...) \
> + pr_debug("%s: " fmt, rdev_get_name(rdev), ##__VA_ARGS__)
> +
This looks good but I'd prefer if this were rdev_dbg() rather than
rdev_debug() to match dev_dbg() - it feels like that would be a better
match given that we're supplying an rdev and it's less typing to boot.
next prev parent reply other threads:[~2010-11-29 22:00 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2010-11-29 19:54 [PATCH] regulator: Add and use rdev_<level> macros Joe Perches
2010-11-29 22:00 ` Mark Brown [this message]
2010-11-30 1:12 ` [PATCH] regulator: Rename rdev_debug to rdev_dbg Joe Perches
2010-11-30 10:52 ` Mark Brown
2010-11-30 13:53 ` [PATCH] regulator: Add and use rdev_<level> macros Joe Perches
2010-11-30 14:23 ` Mark Brown
2010-11-30 15:15 ` Liam Girdwood
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20101129220046.GB8335@opensource.wolfsonmicro.com \
--to=broonie@opensource.wolfsonmicro.com \
--cc=joe@perches.com \
--cc=linux-kernel@vger.kernel.org \
--cc=lrg@slimlogic.co.uk \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.