From: "Alexander V. Lukyanov" <lav@netis.ru>
To: linux-ext4@vger.kernel.org
Cc: "Theodore Ts'o" <tytso@mit.edu>, Andreas Dilger <adilger@sun.com>,
linux-kernel@vger.kernel.org
Subject: [PATCH] allow inode_readahead_blks=0
Date: Tue, 30 Nov 2010 16:52:20 +0300 [thread overview]
Message-ID: <20101130135219.GA22357@proxy> (raw)
[-- Attachment #1: Type: text/plain, Size: 183 bytes --]
Hello!
Currently the value 0 is disallowed, as it is not a power of 2.
This obvious patch fixes the problem.
Signed-off-by: Alexander V. Lukyanov <lav@netis.ru>
--
Alexander.
[-- Attachment #2: diff --]
[-- Type: text/plain, Size: 638 bytes --]
--- fs/ext4/super.c.0 2010-11-16 10:48:33.418629215 +0300
+++ fs/ext4/super.c 2010-11-16 10:46:07.739753246 +0300
@@ -1657,7 +1657,7 @@ set_qf_format:
return 0;
if (option < 0 || option > (1 << 30))
return 0;
- if (!is_power_of_2(option)) {
+ if (option && !is_power_of_2(option)) {
ext4_msg(sb, KERN_ERR,
"EXT4-fs: inode_readahead_blks"
" must be a power of 2");
@@ -2274,7 +2274,7 @@ static ssize_t inode_readahead_blks_stor
if (parse_strtoul(buf, 0x40000000, &t))
return -EINVAL;
- if (!is_power_of_2(t))
+ if (t && !is_power_of_2(t))
return -EINVAL;
sbi->s_inode_readahead_blks = t;
reply other threads:[~2010-11-30 13:53 UTC|newest]
Thread overview: [no followups] expand[flat|nested] mbox.gz Atom feed
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20101130135219.GA22357@proxy \
--to=lav@netis.ru \
--cc=adilger@sun.com \
--cc=linux-ext4@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=tytso@mit.edu \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.