From: Tony Lindgren <tony@atomide.com>
To: Sukumar Ghorai <s-ghorai@ti.com>
Cc: linux-omap@vger.kernel.org, linux-mtd@lists.infradead.org
Subject: Re: [PATCH V2] omap: nand: remove hardware ECC as default
Date: Tue, 30 Nov 2010 10:05:42 -0800 [thread overview]
Message-ID: <20101130180542.GP17222@atomide.com> (raw)
In-Reply-To: <1290177926-3526-1-git-send-email-s-ghorai@ti.com>
* Sukumar Ghorai <s-ghorai@ti.com> [101119 06:36]:
> CONFIG_MTD_NAND_OMAP_HWECC defined wrongly in patch submitted for 2.6.36.
> This flag enables hw ecc by default. Boards like beagle and pandora uses
> sw ecc for write (e.g. binary flushed from u-boot) and read from kernel.
> https://patchwork.kernel.org/patch/111036/
>
> Signed-off-by: Sukumar Ghorai <s-ghorai@ti.com>
This should go in as a fix for the -rc via MTD list if possible.
Acked-by: Tony Lindgren <tony@atomide.com>
> ---
> drivers/mtd/nand/omap2.c | 1 -
> 1 files changed, 0 insertions(+), 1 deletions(-)
>
> diff --git a/drivers/mtd/nand/omap2.c b/drivers/mtd/nand/omap2.c
> index cd41c58..15682ec 100644
> --- a/drivers/mtd/nand/omap2.c
> +++ b/drivers/mtd/nand/omap2.c
> @@ -7,7 +7,6 @@
> * it under the terms of the GNU General Public License version 2 as
> * published by the Free Software Foundation.
> */
> -#define CONFIG_MTD_NAND_OMAP_HWECC
>
> #include <linux/platform_device.h>
> #include <linux/dma-mapping.h>
> --
> 1.7.0.4
>
> --
> To unsubscribe from this list: send the line "unsubscribe linux-omap" in
> the body of a message to majordomo@vger.kernel.org
> More majordomo info at http://vger.kernel.org/majordomo-info.html
next prev parent reply other threads:[~2010-11-30 18:05 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2010-11-19 14:45 [PATCH V2] omap: nand: remove hardware ECC as default Sukumar Ghorai
2010-11-30 18:05 ` Tony Lindgren [this message]
2010-11-30 18:09 ` Tony Lindgren
2010-12-03 16:22 ` Artem Bityutskiy
2010-12-03 16:22 ` Artem Bityutskiy
2010-12-03 16:38 ` David Woodhouse
2010-12-03 16:44 ` Tony Lindgren
2010-12-03 16:44 ` Tony Lindgren
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20101130180542.GP17222@atomide.com \
--to=tony@atomide.com \
--cc=linux-mtd@lists.infradead.org \
--cc=linux-omap@vger.kernel.org \
--cc=s-ghorai@ti.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.