From: Pavel Machek <pavel@ucw.cz>
To: Ingo Molnar <mingo@elte.hu>
Cc: Thomas Gleixner <tglx@linutronix.de>,
Andrew Morton <akpm@linux-foundation.org>,
Peter Zijlstra <a.p.zijlstra@chello.nl>,
Marcus Meissner <meissner@suse.de>,
rusty@rustcorp.com.au, torvalds@linux-foundation.org,
linux-kernel@vger.kernel.org
Subject: Re: [PATCH] kernel/time: Make /proc/timer_list mode 0400
Date: Tue, 30 Nov 2010 20:22:23 +0100 [thread overview]
Message-ID: <20101130192223.GE5295@ucw.cz> (raw)
In-Reply-To: <20101118081241.GA23481@elte.hu>
Hi!
> > > > iirc powertop parses this..
> > >
> > > I bet it doesn't look at the kernel address (why was that added in the
> > > first place, anyway?)
> > >
> > > I'd suggest that the risk of breakage would be much less if we left the
> > > file permissions alone and arranged for those addresses to be
> > > 0000000000000000 for non-root readers.
> >
> > You beat me to it. Having the full information is quite helpful at
> > times.
>
> We should do something like:
>
> if (!capable(CAP_SYS_ADMIN))
> print_ptr = NULL;
>
> sprintf(s, "%p", print_ptr);
Having single file that contains different stuff based on capable() is
very very ugly.
Pavel
--
(english) http://www.livejournal.com/~pavelmachek
(cesky, pictures) http://atrey.karlin.mff.cuni.cz/~pavel/picture/horses/blog.html
prev parent reply other threads:[~2010-11-30 19:22 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2010-11-17 17:08 [PATCH] kernel/time: Make /proc/timer_list mode 0400 Marcus Meissner
2010-11-17 17:18 ` Peter Zijlstra
2010-11-17 17:21 ` Marcus Meissner
2010-11-17 17:33 ` Peter Zijlstra
2010-11-30 19:21 ` Pavel Machek
2010-11-17 20:30 ` Andrew Morton
2010-11-17 20:37 ` Thomas Gleixner
2010-11-18 8:12 ` Ingo Molnar
2010-11-18 8:28 ` Eric Dumazet
2010-11-30 19:22 ` Pavel Machek [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20101130192223.GE5295@ucw.cz \
--to=pavel@ucw.cz \
--cc=a.p.zijlstra@chello.nl \
--cc=akpm@linux-foundation.org \
--cc=linux-kernel@vger.kernel.org \
--cc=meissner@suse.de \
--cc=mingo@elte.hu \
--cc=rusty@rustcorp.com.au \
--cc=tglx@linutronix.de \
--cc=torvalds@linux-foundation.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.