From: kristoffer.ericson@gmail.com (Kristoffer Ericson)
To: linux-arm-kernel@lists.infradead.org
Subject: [PATCH 06/54] ARM: sa1111: irq_data conversion.
Date: Tue, 30 Nov 2010 21:52:52 +0100 [thread overview]
Message-ID: <20101130205252.GB818@boggieman> (raw)
In-Reply-To: <20101130132546.GG15575@mail.wantstofly.org>
On Tue, Nov 30, 2010 at 02:25:46PM +0100, Lennert Buytenhek wrote:
> Signed-off-by: Lennert Buytenhek <buytenh@secretlab.ca>
> ---
It applies cleanly and builds without issues. Its hard to test
since sa1111 isnt working properly (which I will need to fix at later date),
but I dont have any issues with this patch.
So,
Acked-by: Kristoffer Ericson <kristoffer.ericson@gmail.com>
> arch/arm/common/sa1111.c | 94 +++++++++++++++++++++++-----------------------
> 1 files changed, 47 insertions(+), 47 deletions(-)
>
> diff --git a/arch/arm/common/sa1111.c b/arch/arm/common/sa1111.c
> index c0258a8..d6c784e 100644
> --- a/arch/arm/common/sa1111.c
> +++ b/arch/arm/common/sa1111.c
> @@ -210,7 +210,7 @@ sa1111_irq_handler(unsigned int irq, struct irq_desc *desc)
>
> sa1111_writel(stat0, mapbase + SA1111_INTSTATCLR0);
>
> - desc->chip->ack(irq);
> + desc->irq_data.chip->irq_ack(&desc->irq_data);
>
> sa1111_writel(stat1, mapbase + SA1111_INTSTATCLR1);
>
> @@ -228,35 +228,35 @@ sa1111_irq_handler(unsigned int irq, struct irq_desc *desc)
> generic_handle_irq(i + sachip->irq_base);
>
> /* For level-based interrupts */
> - desc->chip->unmask(irq);
> + desc->irq_data.chip->irq_unmask(&desc->irq_data);
> }
>
> #define SA1111_IRQMASK_LO(x) (1 << (x - sachip->irq_base))
> #define SA1111_IRQMASK_HI(x) (1 << (x - sachip->irq_base - 32))
>
> -static void sa1111_ack_irq(unsigned int irq)
> +static void sa1111_ack_irq(struct irq_data *d)
> {
> }
>
> -static void sa1111_mask_lowirq(unsigned int irq)
> +static void sa1111_mask_lowirq(struct irq_data *d)
> {
> - struct sa1111 *sachip = get_irq_chip_data(irq);
> + struct sa1111 *sachip = irq_data_get_irq_chip_data(d);
> void __iomem *mapbase = sachip->base + SA1111_INTC;
> unsigned long ie0;
>
> ie0 = sa1111_readl(mapbase + SA1111_INTEN0);
> - ie0 &= ~SA1111_IRQMASK_LO(irq);
> + ie0 &= ~SA1111_IRQMASK_LO(d->irq);
> writel(ie0, mapbase + SA1111_INTEN0);
> }
>
> -static void sa1111_unmask_lowirq(unsigned int irq)
> +static void sa1111_unmask_lowirq(struct irq_data *d)
> {
> - struct sa1111 *sachip = get_irq_chip_data(irq);
> + struct sa1111 *sachip = irq_data_get_irq_chip_data(d);
> void __iomem *mapbase = sachip->base + SA1111_INTC;
> unsigned long ie0;
>
> ie0 = sa1111_readl(mapbase + SA1111_INTEN0);
> - ie0 |= SA1111_IRQMASK_LO(irq);
> + ie0 |= SA1111_IRQMASK_LO(d->irq);
> sa1111_writel(ie0, mapbase + SA1111_INTEN0);
> }
>
> @@ -267,11 +267,11 @@ static void sa1111_unmask_lowirq(unsigned int irq)
> * be triggered. In fact, its very difficult, if not impossible to get
> * INTSET to re-trigger the interrupt.
> */
> -static int sa1111_retrigger_lowirq(unsigned int irq)
> +static int sa1111_retrigger_lowirq(struct irq_data *d)
> {
> - struct sa1111 *sachip = get_irq_chip_data(irq);
> + struct sa1111 *sachip = irq_data_get_irq_chip_data(d);
> void __iomem *mapbase = sachip->base + SA1111_INTC;
> - unsigned int mask = SA1111_IRQMASK_LO(irq);
> + unsigned int mask = SA1111_IRQMASK_LO(d->irq);
> unsigned long ip0;
> int i;
>
> @@ -285,15 +285,15 @@ static int sa1111_retrigger_lowirq(unsigned int irq)
>
> if (i == 8)
> printk(KERN_ERR "Danger Will Robinson: failed to "
> - "re-trigger IRQ%d\n", irq);
> + "re-trigger IRQ%d\n", d->irq);
> return i == 8 ? -1 : 0;
> }
>
> -static int sa1111_type_lowirq(unsigned int irq, unsigned int flags)
> +static int sa1111_type_lowirq(struct irq_data *d, unsigned int flags)
> {
> - struct sa1111 *sachip = get_irq_chip_data(irq);
> + struct sa1111 *sachip = irq_data_get_irq_chip_data(d);
> void __iomem *mapbase = sachip->base + SA1111_INTC;
> - unsigned int mask = SA1111_IRQMASK_LO(irq);
> + unsigned int mask = SA1111_IRQMASK_LO(d->irq);
> unsigned long ip0;
>
> if (flags == IRQ_TYPE_PROBE)
> @@ -313,11 +313,11 @@ static int sa1111_type_lowirq(unsigned int irq, unsigned int flags)
> return 0;
> }
>
> -static int sa1111_wake_lowirq(unsigned int irq, unsigned int on)
> +static int sa1111_wake_lowirq(struct irq_data *d, unsigned int on)
> {
> - struct sa1111 *sachip = get_irq_chip_data(irq);
> + struct sa1111 *sachip = irq_data_get_irq_chip_data(d);
> void __iomem *mapbase = sachip->base + SA1111_INTC;
> - unsigned int mask = SA1111_IRQMASK_LO(irq);
> + unsigned int mask = SA1111_IRQMASK_LO(d->irq);
> unsigned long we0;
>
> we0 = sa1111_readl(mapbase + SA1111_WAKEEN0);
> @@ -332,33 +332,33 @@ static int sa1111_wake_lowirq(unsigned int irq, unsigned int on)
>
> static struct irq_chip sa1111_low_chip = {
> .name = "SA1111-l",
> - .ack = sa1111_ack_irq,
> - .mask = sa1111_mask_lowirq,
> - .unmask = sa1111_unmask_lowirq,
> - .retrigger = sa1111_retrigger_lowirq,
> - .set_type = sa1111_type_lowirq,
> - .set_wake = sa1111_wake_lowirq,
> + .irq_ack = sa1111_ack_irq,
> + .irq_mask = sa1111_mask_lowirq,
> + .irq_unmask = sa1111_unmask_lowirq,
> + .irq_retrigger = sa1111_retrigger_lowirq,
> + .irq_set_type = sa1111_type_lowirq,
> + .irq_set_wake = sa1111_wake_lowirq,
> };
>
> -static void sa1111_mask_highirq(unsigned int irq)
> +static void sa1111_mask_highirq(struct irq_data *d)
> {
> - struct sa1111 *sachip = get_irq_chip_data(irq);
> + struct sa1111 *sachip = irq_data_get_irq_chip_data(d);
> void __iomem *mapbase = sachip->base + SA1111_INTC;
> unsigned long ie1;
>
> ie1 = sa1111_readl(mapbase + SA1111_INTEN1);
> - ie1 &= ~SA1111_IRQMASK_HI(irq);
> + ie1 &= ~SA1111_IRQMASK_HI(d->irq);
> sa1111_writel(ie1, mapbase + SA1111_INTEN1);
> }
>
> -static void sa1111_unmask_highirq(unsigned int irq)
> +static void sa1111_unmask_highirq(struct irq_data *d)
> {
> - struct sa1111 *sachip = get_irq_chip_data(irq);
> + struct sa1111 *sachip = irq_data_get_irq_chip_data(d);
> void __iomem *mapbase = sachip->base + SA1111_INTC;
> unsigned long ie1;
>
> ie1 = sa1111_readl(mapbase + SA1111_INTEN1);
> - ie1 |= SA1111_IRQMASK_HI(irq);
> + ie1 |= SA1111_IRQMASK_HI(d->irq);
> sa1111_writel(ie1, mapbase + SA1111_INTEN1);
> }
>
> @@ -369,11 +369,11 @@ static void sa1111_unmask_highirq(unsigned int irq)
> * be triggered. In fact, its very difficult, if not impossible to get
> * INTSET to re-trigger the interrupt.
> */
> -static int sa1111_retrigger_highirq(unsigned int irq)
> +static int sa1111_retrigger_highirq(struct irq_data *d)
> {
> - struct sa1111 *sachip = get_irq_chip_data(irq);
> + struct sa1111 *sachip = irq_data_get_irq_chip_data(d);
> void __iomem *mapbase = sachip->base + SA1111_INTC;
> - unsigned int mask = SA1111_IRQMASK_HI(irq);
> + unsigned int mask = SA1111_IRQMASK_HI(d->irq);
> unsigned long ip1;
> int i;
>
> @@ -387,15 +387,15 @@ static int sa1111_retrigger_highirq(unsigned int irq)
>
> if (i == 8)
> printk(KERN_ERR "Danger Will Robinson: failed to "
> - "re-trigger IRQ%d\n", irq);
> + "re-trigger IRQ%d\n", d->irq);
> return i == 8 ? -1 : 0;
> }
>
> -static int sa1111_type_highirq(unsigned int irq, unsigned int flags)
> +static int sa1111_type_highirq(struct irq_data *d, unsigned int flags)
> {
> - struct sa1111 *sachip = get_irq_chip_data(irq);
> + struct sa1111 *sachip = irq_data_get_irq_chip_data(d);
> void __iomem *mapbase = sachip->base + SA1111_INTC;
> - unsigned int mask = SA1111_IRQMASK_HI(irq);
> + unsigned int mask = SA1111_IRQMASK_HI(d->irq);
> unsigned long ip1;
>
> if (flags == IRQ_TYPE_PROBE)
> @@ -415,11 +415,11 @@ static int sa1111_type_highirq(unsigned int irq, unsigned int flags)
> return 0;
> }
>
> -static int sa1111_wake_highirq(unsigned int irq, unsigned int on)
> +static int sa1111_wake_highirq(struct irq_data *d, unsigned int on)
> {
> - struct sa1111 *sachip = get_irq_chip_data(irq);
> + struct sa1111 *sachip = irq_data_get_irq_chip_data(d);
> void __iomem *mapbase = sachip->base + SA1111_INTC;
> - unsigned int mask = SA1111_IRQMASK_HI(irq);
> + unsigned int mask = SA1111_IRQMASK_HI(d->irq);
> unsigned long we1;
>
> we1 = sa1111_readl(mapbase + SA1111_WAKEEN1);
> @@ -434,12 +434,12 @@ static int sa1111_wake_highirq(unsigned int irq, unsigned int on)
>
> static struct irq_chip sa1111_high_chip = {
> .name = "SA1111-h",
> - .ack = sa1111_ack_irq,
> - .mask = sa1111_mask_highirq,
> - .unmask = sa1111_unmask_highirq,
> - .retrigger = sa1111_retrigger_highirq,
> - .set_type = sa1111_type_highirq,
> - .set_wake = sa1111_wake_highirq,
> + .irq_ack = sa1111_ack_irq,
> + .irq_mask = sa1111_mask_highirq,
> + .irq_unmask = sa1111_unmask_highirq,
> + .irq_retrigger = sa1111_retrigger_highirq,
> + .irq_set_type = sa1111_type_highirq,
> + .irq_set_wake = sa1111_wake_highirq,
> };
>
> static void sa1111_setup_irq(struct sa1111 *sachip)
> --
> 1.7.1
next prev parent reply other threads:[~2010-11-30 20:52 UTC|newest]
Thread overview: 102+ messages / expand[flat|nested] mbox.gz Atom feed top
[not found] <cover.1291118519.git.buytenh@wantstofly.org>
2010-11-30 13:25 ` [PATCH 01/54] ARM: core irq_data conversion Lennert Buytenhek
2011-01-14 16:24 ` Russell King - ARM Linux
2011-01-14 18:49 ` Lennert Buytenhek
2010-11-30 13:25 ` [PATCH 02/54] ARM: ecard: " Lennert Buytenhek
2010-12-03 17:23 ` Russell King - ARM Linux
2010-11-30 13:25 ` [PATCH 03/54] ARM: gic: " Lennert Buytenhek
2010-12-01 1:08 ` Abhijeet Dharmapurikar
2010-11-30 13:25 ` [PATCH 04/54] ARM: ITE 8152: " Lennert Buytenhek
2010-11-30 14:02 ` Mike Rapoport
2010-11-30 13:25 ` [PATCH 05/54] ARM: LoCoMo: " Lennert Buytenhek
2010-11-30 13:25 ` [PATCH 06/54] ARM: sa1111: " Lennert Buytenhek
2010-11-30 20:52 ` Kristoffer Ericson [this message]
2010-11-30 13:25 ` [PATCH 07/54] ARM: vic: " Lennert Buytenhek
2010-11-30 13:25 ` [PATCH 08/54] ARM: aaec2000: " Lennert Buytenhek
2010-12-06 11:27 ` Sergei Shtylyov
2010-12-06 11:45 ` Russell King - ARM Linux
2010-11-30 13:25 ` [PATCH 09/54] ARM: at91: " Lennert Buytenhek
2010-11-30 13:25 ` [PATCH 10/54] ARM: bcmring: " Lennert Buytenhek
2010-12-01 0:12 ` Scott Branden
2010-12-01 8:00 ` Uwe Kleine-König
2010-12-01 11:56 ` Lennert Buytenhek
2010-11-30 13:36 ` [PATCH 11/54] ARM: clps711x: " Lennert Buytenhek
2010-11-30 13:36 ` [PATCH 12/54] ARM: davinci: " Lennert Buytenhek
2010-12-06 11:34 ` Sergei Shtylyov
2010-11-30 13:36 ` [PATCH 13/54] ARM: dove: " Lennert Buytenhek
2010-12-01 0:55 ` Nicolas Pitre
2010-11-30 13:36 ` [PATCH 14/54] ARM: ebsa110: " Lennert Buytenhek
2010-12-03 17:22 ` Russell King - ARM Linux
2010-11-30 13:36 ` [PATCH 15/54] ARM: ep93xx: " Lennert Buytenhek
2010-11-30 19:33 ` Ryan Mallon
2010-12-01 0:19 ` Lennert Buytenhek
2010-12-01 0:26 ` Ryan Mallon
2010-12-14 19:28 ` Lennert Buytenhek
2010-12-14 19:52 ` Ryan Mallon
2010-11-30 13:36 ` [PATCH 16/54] ARM: footbridge: " Lennert Buytenhek
2010-12-03 17:24 ` Russell King - ARM Linux
2010-11-30 13:36 ` [PATCH 17/54] ARM: gemini: " Lennert Buytenhek
2010-11-30 14:38 ` Hans Ulli Kroll
2010-11-30 13:36 ` [PATCH 18/54] ARM: h720x: " Lennert Buytenhek
2010-11-30 13:36 ` [PATCH 19/54] ARM: integrator: " Lennert Buytenhek
2010-12-03 17:25 ` Russell King - ARM Linux
2010-11-30 13:36 ` [PATCH 20/54] ARM: iop13xx: " Lennert Buytenhek
2010-12-04 1:18 ` Dan Williams
2010-11-30 13:36 ` [PATCH 21/54] ARM: iop32x: " Lennert Buytenhek
2010-11-30 13:36 ` [PATCH 22/54] ARM: iop33x: " Lennert Buytenhek
2010-12-06 11:39 ` Sergei Shtylyov
2010-11-30 13:36 ` [PATCH 23/54] ARM: ixp2000: " Lennert Buytenhek
2010-11-30 13:36 ` [PATCH 24/54] ARM: ixp23xx: " Lennert Buytenhek
2010-11-30 13:36 ` [PATCH 25/54] ARM: ixp4xx: " Lennert Buytenhek
2010-11-30 13:36 ` [PATCH 26/54] ARM: ks8695: " Lennert Buytenhek
2010-11-30 13:36 ` [PATCH 27/54] ARM: lh7a40x: " Lennert Buytenhek
2010-11-30 13:36 ` [PATCH 28/54] ARM: lpc32xx: " Lennert Buytenhek
2010-11-30 13:36 ` [PATCH 29/54] ARM: mmp: " Lennert Buytenhek
2010-11-30 13:37 ` [PATCH 30/54] ARM: msm: " Lennert Buytenhek
2010-11-30 22:57 ` Daniel Walker
2010-12-01 0:10 ` Lennert Buytenhek
2010-12-01 0:15 ` Daniel Walker
2010-12-01 23:31 ` Gregory Bean
2010-11-30 13:40 ` [PATCH 31/54] ARM: mx3: " Lennert Buytenhek
2010-11-30 13:41 ` [PATCH 32/54] ARM: netx: " Lennert Buytenhek
2010-11-30 13:41 ` [PATCH 33/54] ARM: ns9xxx: " Lennert Buytenhek
2010-12-01 8:05 ` Uwe Kleine-König
2010-11-30 13:41 ` [PATCH 34/54] ARM: nuc93x: " Lennert Buytenhek
2010-12-01 1:47 ` Wan ZongShun
2010-11-30 13:41 ` [PATCH 35/54] ARM: omap1: " Lennert Buytenhek
2010-11-30 13:41 ` Lennert Buytenhek
2010-11-30 13:41 ` [PATCH 36/54] ARM: omap2: " Lennert Buytenhek
2010-11-30 13:41 ` Lennert Buytenhek
2010-11-30 13:41 ` [PATCH 37/54] ARM: pnx4008: " Lennert Buytenhek
2010-11-30 13:41 ` [PATCH 38/54] ARM: PXA SoCs: " Lennert Buytenhek
2010-11-30 13:41 ` [PATCH 39/54] ARM: rpc: " Lennert Buytenhek
2010-12-03 17:26 ` Russell King - ARM Linux
2010-11-30 13:41 ` [PATCH 40/54] ARM: Samsung SoCs: " Lennert Buytenhek
2010-12-03 11:56 ` Kukjin Kim
2010-12-14 19:43 ` 'Lennert Buytenhek'
2010-12-14 22:10 ` 'Lennert Buytenhek'
2010-12-17 5:40 ` Kukjin Kim
2010-12-21 10:03 ` Kukjin Kim
2010-12-21 10:24 ` 'Lennert Buytenhek'
2010-11-30 13:41 ` [PATCH 41/54] ARM: sa1100: " Lennert Buytenhek
2010-11-30 13:41 ` [PATCH 42/54] ARM: shark: " Lennert Buytenhek
2010-11-30 13:41 ` [PATCH 43/54] ARM: stmp378x: " Lennert Buytenhek
2010-11-30 13:41 ` [PATCH 44/54] ARM: stmp37xx: " Lennert Buytenhek
2010-11-30 13:41 ` [PATCH 45/54] ARM: tcc8k: " Lennert Buytenhek
2010-11-30 13:41 ` [PATCH 46/54] ARM: tegra: " Lennert Buytenhek
2010-11-30 13:41 ` [PATCH 47/54] ARM: versatile: " Lennert Buytenhek
2010-12-03 17:26 ` Russell King - ARM Linux
2010-12-06 12:10 ` Sergei Shtylyov
2010-12-06 12:58 ` Russell King - ARM Linux
2010-12-23 18:51 ` Sergei Shtylyov
2010-11-30 13:41 ` [PATCH 48/54] ARM: w90x900: " Lennert Buytenhek
2010-12-01 1:46 ` Wan ZongShun
2010-11-30 13:41 ` [PATCH 49/54] ARM: plat-mxc: " Lennert Buytenhek
2010-11-30 13:41 ` [PATCH 50/54] ARM: plat-nomadik: " Lennert Buytenhek
2010-12-13 3:43 ` Rabin Vincent
2010-11-30 13:41 ` [PATCH 51/54] ARM: plat-omap: " Lennert Buytenhek
2010-11-30 13:41 ` Lennert Buytenhek
2010-11-30 13:41 ` [PATCH 52/54] ARM: plat-orion: " Lennert Buytenhek
2010-12-01 0:54 ` Nicolas Pitre
2010-11-30 13:41 ` [PATCH 53/54] ARM: plat-spear: " Lennert Buytenhek
2010-12-01 4:02 ` viresh kumar
2010-11-30 13:41 ` [PATCH 54/54] ARM: plat-stmp3xxx: " Lennert Buytenhek
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20101130205252.GB818@boggieman \
--to=kristoffer.ericson@gmail.com \
--cc=linux-arm-kernel@lists.infradead.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.