All of lore.kernel.org
 help / color / mirror / Atom feed
From: Gabriele Gorla <gorlik@penguintown.net>
To: lm-sensors@vger.kernel.org
Subject: Re: [lm-sensors] [PATCH] adm1026: fix setting fan_div
Date: Wed, 01 Dec 2010 01:05:48 +0000	[thread overview]
Message-ID: <20101201010548.GF30973@penguintown.net> (raw)
In-Reply-To: <20101130014623.GA26439@penguintown.net>

Thanks everyone for the feedback.

I resubmitted 2 bugfixes only patches:
1- to fix the div setting
2- stop rejecting div=1 since it is valid

I left the locking around the entire structure access as requested.

I can submit another patch to validate the input to 1,2,4,8 to be applied in the development 
kernels.

I am not sure if we reached an agreement on the internal representation of fan_div so I 
am leaving it alone for now.

thanks,
GG

_______________________________________________
lm-sensors mailing list
lm-sensors@lm-sensors.org
http://lists.lm-sensors.org/mailman/listinfo/lm-sensors

  parent reply	other threads:[~2010-12-01  1:05 UTC|newest]

Thread overview: 14+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2010-11-30  1:49 [lm-sensors] [PATCH] adm1026: fix setting fan_div Gabriele Gorla
2010-11-30  2:29 ` Phil Pokorny
2010-11-30  8:04 ` Gabriele Gorla
2010-11-30  9:17 ` Jean Delvare
2010-11-30 15:50 ` Guenter Roeck
2010-11-30 19:05 ` Phil Pokorny
2010-11-30 19:10 ` Gabriele Gorla
2010-11-30 19:19 ` Phil Pokorny
2010-11-30 19:44 ` Jean Delvare
2010-11-30 20:30 ` Jean Delvare
2010-12-01  1:05 ` Gabriele Gorla [this message]
2010-12-01  2:46 ` Phil Pokorny
2010-12-01  8:18 ` Jean Delvare
2010-12-01  8:55 ` Jean Delvare

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20101201010548.GF30973@penguintown.net \
    --to=gorlik@penguintown.net \
    --cc=lm-sensors@vger.kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.