From: Dave Chinner <david@fromorbit.com>
To: Christoph Hellwig <hch@infradead.org>
Cc: xfs@oss.sgi.com
Subject: Re: [PATCH 03/10] xfs: a few small tweaks for overwrites in xfs_vm_writepage
Date: Wed, 1 Dec 2010 15:07:04 +1100 [thread overview]
Message-ID: <20101201040704.GD16922@dastard> (raw)
In-Reply-To: <20101122130903.533699161@bombadil.infradead.org>
On Mon, Nov 22, 2010 at 08:05:09AM -0500, Christoph Hellwig wrote:
> Don't trylock the buffer. We are the only one ever locking it for
> a regular file address space, and trylock was only copied from the
> generic code which did it due to the old buffer based writeout in
> jbd. Also make sure to only write out the buffer if the iomap
> actually is valid, because we wouldn't have a proper mapping
> otherwise. In practice we will never get an invalid mapping here
> as the page lock guarantees truncate doesn't race with us, but
> better be safe than sorry. Also make sure we allocate a new ioend
> when crossing boundaries between mappings, just like we do for
> delalloc and unwritten extents. Again this currently doesn't
> matter as the I/O end handler only cares for the boundaries for
> unwritten extents, but this makes the code fully correct and the
> same as for delalloc/unwritten extents.
>
> Signed-off-by: Christoph Hellwig <hch@lst.de>
Reviewed-by: Dave Chinner <dchinner@redhat.com>
--
Dave Chinner
david@fromorbit.com
_______________________________________________
xfs mailing list
xfs@oss.sgi.com
http://oss.sgi.com/mailman/listinfo/xfs
next prev parent reply other threads:[~2010-12-01 4:05 UTC|newest]
Thread overview: 22+ messages / expand[flat|nested] mbox.gz Atom feed top
2010-11-22 13:05 [PATCH 00/10] writeback updates Christoph Hellwig
2010-11-22 13:05 ` [PATCH 01/10] xfs: improve mapping type check in xfs_vm_writepage Christoph Hellwig
2010-12-01 4:01 ` Dave Chinner
2010-11-22 13:05 ` [PATCH 02/10] xfs: remove some dead bio handling code Christoph Hellwig
2010-12-01 4:02 ` Dave Chinner
2010-11-22 13:05 ` [PATCH 03/10] xfs: a few small tweaks for overwrites in xfs_vm_writepage Christoph Hellwig
2010-12-01 4:07 ` Dave Chinner [this message]
2010-11-22 13:05 ` [PATCH 04/10] xfs: cleanup the xfs_iomap_write_* helpers Christoph Hellwig
2010-12-01 4:11 ` Dave Chinner
2010-11-22 13:05 ` [PATCH 05/10] xfs: kill xfs_iomap Christoph Hellwig
2010-12-01 4:32 ` Dave Chinner
2010-11-22 13:05 ` [PATCH 06/10] xfs: simplify xfs_map_blocks Christoph Hellwig
2010-12-01 4:41 ` Dave Chinner
2010-11-22 13:05 ` [PATCH 07/10] xfs: remove xfs_probe_cluster Christoph Hellwig
2010-12-01 4:43 ` Dave Chinner
2010-11-22 13:05 ` [PATCH 08/10] xfs: remove the all_bh flag from xfs_convert_page Christoph Hellwig
2010-12-01 4:45 ` Dave Chinner
2010-11-22 13:05 ` [PATCH 09/10] xfs: refactor xfs_vm_writepage Christoph Hellwig
2010-12-01 4:49 ` Dave Chinner
2010-11-22 13:05 ` [PATCH 10/10] xfs: simplify xfs_map_at_offset Christoph Hellwig
2010-12-01 4:50 ` Dave Chinner
-- strict thread matches above, loose matches on Subject: below --
2010-12-10 8:42 [PATCH 00/10] writeback updates V2 Christoph Hellwig
2010-12-10 8:42 ` [PATCH 03/10] xfs: a few small tweaks for overwrites in xfs_vm_writepage Christoph Hellwig
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20101201040704.GD16922@dastard \
--to=david@fromorbit.com \
--cc=hch@infradead.org \
--cc=xfs@oss.sgi.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.