From: Wolfgang Denk <wd@denx.de>
To: u-boot@lists.denx.de
Subject: [U-Boot] onenand_ipl config.mk cleanup (was: no subject)
Date: Wed, 01 Dec 2010 09:03:42 +0100 [thread overview]
Message-ID: <20101201080342.D5630134FEF@gemini.denx.de> (raw)
In-Reply-To: <AANLkTik64Heh+ooov9K10pixh9h=GdxqRQYyS8Er-c-1@mail.gmail.com>
Dear Minkyu Kang,
In message <AANLkTik64Heh+ooov9K10pixh9h=GdxqRQYyS8Er-c-1@mail.gmail.com> you wrote:
>
> > "onenand_ipl/board/apollon/config.mk" and
> > "onenand_ipl/board/vpac270/config.mk" define CONFIG_SYS_TEXT_BASE;
> > do you think it is possible to move these definitions into the
> > respective board config files and remove the then empty "config.mk"
> > files?
> >
>
> It is hard to move into board config file, because of usually use
> different TEXT_BASE on IPL.
Well, we can probably use #ifdef's, like we do for boards that boot
from NAND flash, which have essentially the same situation.
> I think, it can be moved into Makefile directly.
No, that's not a good idea. Makefiles should not contain configuration
data. I want to move as much of this as possible into the board config
files, so we have it all in a single place.
Best regards,
Wolfgang Denk
--
DENX Software Engineering GmbH, MD: Wolfgang Denk & Detlev Zundel
HRB 165235 Munich, Office: Kirchenstr.5, D-82194 Groebenzell, Germany
Phone: (+49)-8142-66989-10 Fax: (+49)-8142-66989-80 Email: wd at denx.de
A failure will not appear until a unit has passed final inspection.
prev parent reply other threads:[~2010-12-01 8:03 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2010-11-28 20:14 [U-Boot] (no subject) Wolfgang Denk
2010-12-01 6:38 ` Minkyu Kang
2010-12-01 8:03 ` Wolfgang Denk [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20101201080342.D5630134FEF@gemini.denx.de \
--to=wd@denx.de \
--cc=u-boot@lists.denx.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.