From: Paul Mundt <lethal@linux-sh.org>
To: linux-fbdev@vger.kernel.org
Subject: Re: [PATCH] video: da8xx: Register IRQ as last thing in driver probing.
Date: Wed, 01 Dec 2010 09:19:59 +0000 [thread overview]
Message-ID: <20101201091959.GB2982@linux-sh.org> (raw)
On Tue, Nov 30, 2010 at 10:04:14PM +0200, caglarakyuz@gmail.com wrote:
> From: Caglar Akyuz <caglar@bilkon-kontrol.com.tr>
>
> Following commit exposed a bug in driver:
>
> "fbdev: da8xx/omap-l1xx: implement double buffering"
>
> Bug is, if interrupt handler is called before initialization is
> finished, raster controller is enabled and following register
> modifications causes hardware to stay in a broken state.
>
> By looking at this one may say that proper locking is missing in
> this driver, and a more proper fix should be prepared. However,
> aformentioned commit causes a regression in the driver and some
> fix to current one should be applied first.
>
> Signed-off-by: Caglar Akyuz <caglar@bilkon-kontrol.com.tr>
Barring any objections from the davinci folks, I've queued this up.
next reply other threads:[~2010-12-01 9:19 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2010-12-01 9:19 Paul Mundt [this message]
-- strict thread matches above, loose matches on Subject: below --
2010-11-30 20:04 [PATCH] video: da8xx: Register IRQ as last thing in driver probing caglarakyuz
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20101201091959.GB2982@linux-sh.org \
--to=lethal@linux-sh.org \
--cc=linux-fbdev@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.