All of lore.kernel.org
 help / color / mirror / Atom feed
From: zkabelac@sourceware.org <zkabelac@sourceware.org>
To: lvm-devel@redhat.com
Subject: LVM2 ./WHATS_NEW lib/format1/disk-rep.c
Date: 1 Dec 2010 10:33:57 -0000	[thread overview]
Message-ID: <20101201103357.19576.qmail@sourceware.org> (raw)

CVSROOT:	/cvs/lvm2
Module name:	LVM2
Changes by:	zkabelac at sourceware.org	2010-12-01 10:33:56

Modified files:
	.              : WHATS_NEW 
	lib/format1    : disk-rep.c 

Log message:
	Fallback to full rescan for missing device
	
	Fix bug when NULL could have been passsed as 'data'
	to _add_pv_to_list() if 'dev' is NULL.
	
	Now it fallbacks to complete scan.

Patches:
http://sourceware.org/cgi-bin/cvsweb.cgi/LVM2/WHATS_NEW.diff?cvsroot=lvm2&r1=1.1819&r2=1.1820
http://sourceware.org/cgi-bin/cvsweb.cgi/LVM2/lib/format1/disk-rep.c.diff?cvsroot=lvm2&r1=1.82&r2=1.83

--- LVM2/WHATS_NEW	2010/11/30 23:03:35	1.1819
+++ LVM2/WHATS_NEW	2010/12/01 10:33:55	1.1820
@@ -1,5 +1,6 @@
 Version 2.02.78 - 
 ====================================
+  Do a full rescan if some device is missing in read_pvs_in_vg().
   Avoid misleading warnings in vgextend --restoremissing in certain cases.
   Add error path stack traces for _process_mapper_dir(), _create_and_load_v4().
   Add missing test for failed pool allocation in write_config_node().
--- LVM2/lib/format1/disk-rep.c	2010/09/30 21:06:51	1.82
+++ LVM2/lib/format1/disk-rep.c	2010/12/01 10:33:56	1.83
@@ -471,7 +471,7 @@
 	    vginfo->infos.n) {
 		dm_list_iterate_items(info, &vginfo->infos) {
 			dev = info->dev;
-			if (dev && !(data = read_disk(fmt, dev, mem, vg_name)))
+			if (!dev || !(data = read_disk(fmt, dev, mem, vg_name)))
 				break;
 			_add_pv_to_list(head, data);
 		}



             reply	other threads:[~2010-12-01 10:33 UTC|newest]

Thread overview: 2+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2010-12-01 10:33 zkabelac [this message]
  -- strict thread matches above, loose matches on Subject: below --
2008-11-03 16:26 LVM2 ./WHATS_NEW lib/format1/disk-rep.c agk

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20101201103357.19576.qmail@sourceware.org \
    --to=zkabelac@sourceware.org \
    --cc=lvm-devel@redhat.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.