From mboxrd@z Thu Jan  1 00:00:00 1970
Received: from [140.186.70.92] (port=49234 helo=eggs.gnu.org)
	by lists.gnu.org with esmtp (Exim 4.43) id 1PNoml-00024q-O9
	for qemu-devel@nongnu.org; Wed, 01 Dec 2010 10:40:02 -0500
Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71)
	(envelope-from <froydnj@codesourcery.com>) id 1PNoma-0001ar-2X
	for qemu-devel@nongnu.org; Wed, 01 Dec 2010 10:39:59 -0500
Received: from mail.codesourcery.com ([38.113.113.100]:34965)
	by eggs.gnu.org with esmtp (Exim 4.71)
	(envelope-from <froydnj@codesourcery.com>) id 1PNomZ-0001ab-PQ
	for qemu-devel@nongnu.org; Wed, 01 Dec 2010 10:39:48 -0500
Date: Wed, 1 Dec 2010 07:39:44 -0800
From: Nathan Froyd <froydnj@codesourcery.com>
Subject: Re: [Qemu-devel] [PATCH 08/12] ARM: Return correct result for
	single<->double conversion of NaN
Message-ID: <20101201153944.GG24280@codesourcery.com>
References: <1290538431-13170-1-git-send-email-peter.maydell@linaro.org>
	<1290538431-13170-9-git-send-email-peter.maydell@linaro.org>
	<20101129174928.GE8544@codesourcery.com>
	<AANLkTimtk9RwFEt75TFy1CG1=yL-X06-hci_AB2BRozK@mail.gmail.com>
	<20101129195453.GP8544@codesourcery.com>
	<AANLkTimX77efnTfm=MbVifXRjBJ=ix2y3foyeAnJ=DVQ@mail.gmail.com>
MIME-Version: 1.0
Content-Type: text/plain; charset=iso-8859-1
Content-Disposition: inline
Content-Transfer-Encoding: 8bit
In-Reply-To: <AANLkTimX77efnTfm=MbVifXRjBJ=ix2y3foyeAnJ=DVQ@mail.gmail.com>
List-Id: qemu-devel.nongnu.org
List-Unsubscribe: <http://lists.nongnu.org/mailman/listinfo/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=unsubscribe>
List-Archive: <http://lists.nongnu.org/archive/html/qemu-devel>
List-Post: <mailto:qemu-devel@nongnu.org>
List-Help: <mailto:qemu-devel-request@nongnu.org?subject=help>
List-Subscribe: <http://lists.nongnu.org/mailman/listinfo/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=subscribe>
To: Peter Maydell <peter.maydell@linaro.org>
Cc: qemu-devel@nongnu.org, rth@twiddle.net

On Tue, Nov 30, 2010 at 11:15:56AM +0000, Peter Maydell wrote:
> On 29 November 2010 19:54, Nathan Froyd <froydnj@codesourcery.com> wrote:
> > Yes, this is ugly.  Are you up for running:
> >
> >  perl -p -i -e 's/float(\d+)_is_nan/float\1_is_quiet_nan/g' target-*/*.c
> >
> > (and also carefully in fpu/*) or similar and moving the bit-twiddling
> > float_is_nan into fpu/?
> 
> I'm just compiling this up now. While I was eyeballing the results of
> the substitution, I noticed that there are some places which are almost
> certainly bugs introduced by other people not noticing that float*_is_nan()
> doesn't do what it says on the tin. Three at random:
> 
> In target-ppc/op_helper.c:helper_compute_fprf():
> 
> In target-alpha/op_helper.c:helper_cmptun():
> 
> In target-m68k/helper.c:sub_cmp_f64:
> 
> judging from the comments the author expected is_nan() to
> be true for all NaNs.
> 
> I'm not sure what we should do about these -- they look wrong
> but I don't have any of the setup to actually test whether they're
> wrong.

RTH (CC'd) is the expert on the Alpha bits.  The PPC one is obviously
wrong.  I can test the m68k one.

In any event, I think the safest course is to do the simple renaming; we
can clean up broken bits after the fact.

-Nathan